Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure multiple schedulers: switch to the secure ports #31419

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Configure multiple schedulers: switch to the secure ports #31419

merged 1 commit into from
Feb 1, 2022

Conversation

ingvagabund
Copy link
Contributor

@ingvagabund ingvagabund commented Jan 20, 2022 •
edited
Loading

Starting v1.23 the kube-scheduler no longer provides insecure serving. Please see kubernetes/kubernetes#102857 for more details.

Configuring the probes to check the healthz endpoint on port 10251 with http protocol will crash loop back the container.

Also, aligning some of the changes performed in #30107 for other language variants.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language labels Jan 20, 2022
@ingvagabund ingvagabund mentioned this pull request Jan 20, 2022
Closed
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 20, 2022
@ingvagabund ingvagabund force-pushed the multiple-schedulers-fix-secure-port branch from d357e15 to 8f4290f Compare January 20, 2022 13:30
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2022
@ingvagabund ingvagabund force-pushed the multiple-schedulers-fix-secure-port branch from 8f4290f to 9985b6d Compare January 20, 2022 13:32
@ingvagabund
Copy link
Contributor Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jan 20, 2022
@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: d357e15

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61e962bc88613600072f203f

😎 Browse the preview: https://deploy-preview-31419--kubernetes-io-main-staging.netlify.app

@netlify
Copy link

netlify bot commented Jan 20, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: a475c21

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61f9058186942f0008084f64

😎 Browse the preview: https://deploy-preview-31419--kubernetes-io-main-staging.netlify.app

@Babapool
Copy link
Member

Babapool commented Feb 1, 2022

Hi @ingvagabund, Thank your your contribution.
Can you please remove the changes to the ja and zh localizations(from this PR). After the changes to en have been merged then we can open changes for localizations (i.e. subsequent PRs for each localization.). Thanks!

@ingvagabund
Configure multiple schedulers: switch to the secure ports
a475c21 
Starting v1.23 the kube-scheduler no longer provides insecure serving.
@ingvagabund ingvagabund force-pushed the multiple-schedulers-fix-secure-port branch from 9985b6d to a475c21 Compare February 1, 2022 10:03
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2022
@ingvagabund
Copy link
Contributor Author

@Babapool I have updated the PR and removed other language variants as suggested.

@jimangel
Copy link
Member

jimangel commented Feb 1, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e1aa024c86bd29de07cd0e5804076be1bd95e4d5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5313a87 into kubernetes:main Feb 1, 2022
@ingvagabund ingvagabund deleted the multiple-schedulers-fix-secure-port branch February 1, 2022 16:53
@Babapool Babapool mentioned this pull request Apr 20, 2022
Closed
9 tasks
@Huang-Wei Huang-Wei mentioned this pull request Aug 18, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bells17 bells17 Awaiting requested review from bells17

@bradtopol bradtopol Awaiting requested review from bradtopol

Assignees

@jimangel jimangel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ingvagabund @Babapool @jimangel @k8s-ci-robot