Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed: link to broken RSS feed #31624

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Removed: link to broken RSS feed #31624

merged 1 commit into from
Feb 9, 2022

Conversation

agamdua
Copy link
Contributor

@agamdua agamdua commented Feb 4, 2022 •
edited
Loading

It has been removed from one place previously:
d55d770

This changes only en: ko and zh will be separate patches.

Signed-off-by: Agam Dua agam_dua@apple.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @agamdua!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 4, 2022
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 4, 2022
@netlify
Copy link

netlify bot commented Feb 4, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 9486fa2

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/620179efae5dc80007ed3896

😎 Browse the preview: https://deploy-preview-31624--kubernetes-io-main-staging.netlify.app

@Babapool
Copy link
Member

Babapool commented Feb 5, 2022

Hi @agamdua , thank you for your contribution and welcome to Kubernetes!
Can you please remove the changes to the ja and zh localizations(from this PR). After the changes to en have been merged then we can open changes for localizations (i.e. subsequent PRs for each localization.).
Thanks!

@agamdua
Removed: link to broken RSS feed
9486fa2 
It has been removed from one place previously:
kubernetes@d55d770

This changes only `en`: `ko` and `zh` will be separate patches.

Signed-off-by: Agam Dua <agam_dua@apple.com>
@agamdua
Copy link
Contributor Author

agamdua commented Feb 7, 2022

Thanks for the quick look, @Babapool!
I have updated the PR - the patch is just for en now.

@jihoon-seo
Copy link
Member

/remove-language ko
/remove-language zh
/lgtm

@k8s-ci-robot k8s-ci-robot removed language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language labels Feb 9, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5d97ba0fff6f5aca3509be2e10bea21b825e9320

@jihoon-seo jihoon-seo mentioned this pull request Feb 9, 2022
Merged
@tengqm
Copy link
Contributor

tengqm commented Feb 9, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3e8de6b into kubernetes:main Feb 9, 2022
@agamdua agamdua deleted the remove-broken-rss-link branch February 24, 2022 06:13
@Babapool Babapool mentioned this pull request Apr 20, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eparis eparis Awaiting requested review from eparis

@pigletfly pigletfly Awaiting requested review from pigletfly

Assignees

@jihoon-seo jihoon-seo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agamdua @k8s-ci-robot @Babapool @jihoon-seo @tengqm