Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about finding the runtime endpoint #32132

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Add info about finding the runtime endpoint #32132

merged 1 commit into from
Apr 13, 2022

Conversation

shannonxtreme
Copy link
Contributor

Fixes #30974

Add a section to "Find out what container runtime is used on a node" to find the runtime endpoint, with a clarification that Docker users who use cri-dockerd already wouldn't be affected by the dockershim removal.

/sig docs
/language en
/cc @sftim @afbjorklund

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2022
@netlify
Copy link

netlify bot commented Mar 9, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit d3ad42f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6256ee2820cb5100082244a0
😎 Deploy Preview https://deploy-preview-32132--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim
sftim reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shannonxtreme

Here's some tweaks I thought of. I hope these help.

content/en/docs/tasks/administer-cluster/migrating-from-dockershim/find-out-runtime-you-use.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/migrating-from-dockershim/find-out-runtime-you-use.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/migrating-from-dockershim/find-out-runtime-you-use.md Outdated Show resolved Hide resolved
@shannonxtreme shannonxtreme force-pushed the dockershim-am-i-on-dockerhsim branch from 317ed75 to 2dbed30 Compare March 15, 2022 17:30
@shannonxtreme shannonxtreme requested a review from sftim March 15, 2022 17:30
@shannonxtreme
Copy link
Contributor Author

@sftim I changed the commands to look for the kubelet process cmdline and analyse the --container-runtime-endpoint flag (or lack of it) to see what the runtime and socket are.

@sftim
Copy link
Contributor

sftim commented Mar 15, 2022

@kubernetes/sig-node-pr-reviews does this look technically correct?

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 15, 2022
@shannonxtreme shannonxtreme force-pushed the dockershim-am-i-on-dockerhsim branch from 2dbed30 to 9244b10 Compare March 15, 2022 18:02
@shannonxtreme shannonxtreme requested a review from sftim March 15, 2022 20:14
@shannonxtreme
Copy link
Contributor Author

@kubernetes/sig-node-pr-reviews this would be great to get an LGTM on asap :)

@chris-short
Copy link
Contributor

Should we mention the kubectl-detector-for-docker-socket tool here? https://github.com/aws-containers/kubectl-detector-for-docker-socket

@sftim
Copy link
Contributor

sftim commented Mar 31, 2022

It's third party software. On the other hand it's tool to accomplish this specific task. I'd suggest that we mention the tool, but link to it rather than document how to use it (which is what https://kubernetes.io/docs/contribute/style/content-guide/#what-s-allowed cares about).

@sftim
Copy link
Contributor

sftim commented Apr 12, 2022

@kubernetes/sig-node-pr-reviews does this change look OK from a technical perspective? Any concerns?

@derekwaynecarr
Copy link
Member

this looks fine for sig-node.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 548a065d5b0113c3841a4cf9fb8ce9f20193e459

@nate-double-u
Copy link
Contributor

/lgtm
thanks @shannonxtreme!

SergeyKanzhelev
SergeyKanzhelev reviewed Apr 12, 2022
View reviewed changes
content/en/docs/tasks/administer-cluster/migrating-from-dockershim/find-out-runtime-you-use.md Outdated
In some cases, you might find it useful to know which socket your nodes use. For
example, with the removal of dockershim in Kubernetes 1.24 and later, Docker
Engine cannot communicate with the kubelet if it listens on the
`unix:///var/run/dockershim.sock` endpoint.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this sentence. What communication Between Docker and kubelet is meant here? It is typically kubelet calls into the docker and it uses docker.sock to call to it. dokershim.sock is only exposed by kubelet to emulate the CRI from dockershim

SergeyKanzhelev
SergeyKanzhelev reviewed Apr 12, 2022
View reviewed changes
content/en/docs/tasks/administer-cluster/migrating-from-dockershim/find-out-runtime-you-use.md
process manually.

1. In the output, look for the `--container-runtime` flag and the
`--container-runtime-endpoint` flag.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just looking at container-runtime should be enough. If not remote than it's dockershim

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple of tweaks.

@shannonxtreme shannonxtreme force-pushed the dockershim-am-i-on-dockerhsim branch from 9244b10 to d3ad42f Compare April 13, 2022 15:37
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2022
sftim
sftim approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes since most recent LGTM are trivial (or trivial enough).

/lgtm
/approve

Thanks @shannonxtreme

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bf15a856378ecc3a7ed9c1f94e6b3aa4d572be1e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit c6472cb into kubernetes:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@sftim sftim sftim approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@nate-double-u nate-double-u

@derekwaynecarr derekwaynecarr

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explain how to tell dockershim apart from cri-dockerd
7 participants
@shannonxtreme @sftim @chris-short @derekwaynecarr @k8s-ci-robot @nate-double-u @SergeyKanzhelev