-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource constraints and oldSelf context into validation rule #32425
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
4dadd28
to
f7f1b73
Compare
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
@kubernetes/sig-docs-en-owners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I've made a few suggestions from a technical writing perspective; I hope they're helpful.
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
- CEL standard functions, defined in the[list of standard definitions](https://github.com/google/cel-spec/blob/v0.7.0/doc/langdef.md#list-of-standard-definitions) | ||
- CEL standard [macros](https://github.com/google/cel-spec/blob/v0.7.0/doc/langdef.md#macros) | ||
- CEL [extended string function library](https://pkg.go.dev/github.com/google/cel-go@v0.11.2/ext#Strings) | ||
- Kubernetes [CEL extension library](https://pkg.go.dev/k8s.io/apiextensions-apiserver@v0.24.0-alpha.4/pkg/apiserver/schema/cel/library#pkg-functions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is v0.24.0-alpha.4
the right version to hyperlink to?
(there's a wider question of how we find a way to link to the right version of a package and keep that current with each Kubernetes release; the best approach for now is that each SIG is responsible for docs updates to any links to packages that the SIG maintains).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We plan to update the link to the formal release version after 1.24 were cut. Thanks for the reminder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version is updated to beta.0
now which is the latest release tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my previous confusion. I have updated the link which will be available with 1.24 release
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
Hi @sftim , Thank you so much for your review. Your comments are addressed. Please feel free to take a look when have time. Thank you |
Gentle reminder^ @sftim |
@kubernetes/sig-docs-en-owners Gentle reminder on this pr. Thank you^ |
Based on https://github.com/kubernetes/website/pull/32425/files#r844493647 Hyperlink is not yet quite right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits; otherwise, this is ready for tech review.
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
Hi @jpbetz (or SIG API Machinery more widely). With these latest changes, is this proposed text technically correct? |
I just did a full read through a few minutes ago and it all made sense to me technically. |
Regarding with this one, |
Friendly reminder since approaching the doc deadline :). Would it be possible to get approval on this pr when you have time? Thank you @sftim |
Preview of updated section on the CRD page: Link in Kubernetes CEL extension library is for the link that will be available when v1.24.0 is released. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig api-machinery |
Re-applying lgtm from @jpbetz and confirmation after changes |
LGTM label has been added. Git tree hash: ee17371d9e3b4dfd5550ea4929c71964a81ca9b2
|
/unhold |
This is the placeholder pr to add resource constraints and oldSelf context into validation rule section.
The related PR:
kubernetes/enhancements#3160;
kubernetes/enhancements#3132;
kubernetes/enhancements#3144;
kubernetes/enhancements#3232