Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Documentation for PodHealthyPolicy #32567

Closed
wants to merge 1 commit into from
Closed

[WIP] Documentation for PodHealthyPolicy #32567

wants to merge 1 commit into from

Conversation

mortent
Copy link
Member

@mortent mortent commented Mar 28, 2022 •
edited
Loading

Placeholder PR

Enhancement issue: kubernetes/enhancements#3017
Kubernetes PR: kubernetes/kubernetes#108233

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 28, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2022
@netlify
Copy link

netlify bot commented Mar 28, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit af326ae
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/624106895abc5400095259c0

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 28, 2022
@k8s-ci-robot k8s-ci-robot requested a review from kbhawkey March 28, 2022 00:40
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pi-victor after the PR has been reviewed.
You can assign the PR to them by writing /assign @pi-victor in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 28, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim March 28, 2022 00:40
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 28, 2022
@mortent mortent mentioned this pull request Mar 28, 2022
Closed
12 tasks
@tengqm
Copy link
Contributor

tengqm commented Mar 28, 2022

what's happening to the other gates in the table?

@mortent
Copy link
Member Author

mortent commented Mar 28, 2022

@tengqm Yeah, I was wondering the same thing. I will figure it out.

@mortent mortent force-pushed the PDBPodHealthyPolicyDocs branch from c57f530 to af326ae Compare March 28, 2022 00:51
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2022
@mehabhalodiya
Copy link
Contributor

/assign

@mehabhalodiya
Copy link
Contributor

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2022
@k8s-ci-robot
Copy link
Contributor

@mortent: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mehabhalodiya
Copy link
Contributor

mehabhalodiya commented Apr 26, 2022 •
edited
Loading

@mortent any updates?
I see that the enhancement issue is no more tracked!
I recommend that you keep this text ready for a future branch, but close this PR.

@mehabhalodiya
Copy link
Contributor

The v1.24 milestone no longer tracks the KEP that this PR supports. Thanks for your effort on this documentation; I recommend saving this work for a future release.

/close

If you feel that this PR has been closed in error, please feel free to reopen it against another branch.
Thank you!

@k8s-ci-robot
Copy link
Contributor

@mehabhalodiya: Closed this PR.

In response to this:

The v1.24 milestone no longer tracks the KEP that this PR supports. Thanks for your effort on this documentation; I recommend saving this work for a future release.

/close

If you feel that this PR has been closed in error, please feel free to reopen it against another branch.
Thank you!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@mehabhalodiya: Closed this PR.

In response to this:

The v1.24 milestone no longer tracks the KEP that this PR supports. Thanks for your effort on this documentation; I recommend saving this work for a future release.

/close

If you feel that this PR has been closed in error, please feel free to reopen it against another branch.
Thank you!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nate-double-u
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the 1.24 milestone Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@sftim sftim Awaiting requested review from sftim

Assignees

@mehabhalodiya mehabhalodiya

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mortent @k8s-ci-robot @tengqm @mehabhalodiya @nate-double-u