Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog article about volume expansion graduating to GA #32663

Merged
merged 20 commits into from
May 3, 2022

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Mar 30, 2022

Blog post for volume expansion going GA

Xref kubernetes/enhancements#284

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 30, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2022
@netlify
Copy link

netlify bot commented Mar 30, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit ab6c27a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6244bdcdb78c6d000937a9cd

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Mar 30, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 30, 2022
@sftim
Copy link
Contributor

sftim commented Mar 30, 2022

/retitle [WIP] Add blog article about volume expansion graduating to GA

@k8s-ci-robot k8s-ci-robot changed the title volume expansion goes ga [WIP] Add blog article about volume expansion graduating to GA Mar 30, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2022
@katcosgrove
Copy link
Contributor

Hey there! I'm from the Comms team, and I wanted to check on the status of this blog. Reviews for feature blogs are supposed to start next week. Anything we can help you with?

sftim
sftim previously requested changes Apr 10, 2022
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blog articles that are for publication after the v1.24 release should target main (and not dev-1.24).

Please change the base branch for this PR; it will save you time if you can do that before you start work.

@gnufied gnufied changed the base branch from dev-1.24 to main April 12, 2022 19:13
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 12, 2022
@netlify
Copy link

netlify bot commented Apr 12, 2022

Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 0854736
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62710f653ab597000817ab38
😎 Deploy Preview https://deploy-preview-32663--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gnufied gnufied changed the title [WIP] Add blog article about volume expansion graduating to GA Add blog article about volume expansion graduating to GA Apr 12, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 12, 2022
@gnufied
Copy link
Member Author

gnufied commented Apr 12, 2022

Added content of the blog post and it is ready for review. cc @xing-yang @jingxu97 @jsafrane

gnufied and others added 5 commits April 25, 2022 12:54
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2022
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@gnufied
Copy link
Member Author

gnufied commented Apr 25, 2022

@sftim please take another look. I have addressed your comments.

@mickeyboxell
Copy link
Contributor

@gnufied could we plan to have this ship on 5-MAY-2022?

Co-authored-by: Mickey Boxell <mickey.boxell@oracle.com>
@gnufied
Copy link
Member Author

gnufied commented Apr 29, 2022

@mickeyboxell sounds fine!

@mickeyboxell
Copy link
Contributor

mickeyboxell commented Apr 29, 2022

@gnufied Please change the title to 2022-05-05-volume-expansion-ga.md :)


When volume expansion was introduced as an alpha feature, Kubernetes only supported offline filesystem
expansion on the node and hence required users to restart their pods for file system resizing to finish.
his behaviour has been changed and Kubernetes tries its best to fulfil any resize request regardless
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: his -> this

@xing-yang
Copy link
Contributor

Just a minor comment. lgtm other than that.

Follow the informal convention for post-release communications.
@@ -0,0 +1,104 @@
---
layout: blog
title: "Volume expansion now available as stable feature in Kubernetes 1.24"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "Volume expansion now available as stable feature in Kubernetes 1.24"
title: "Kubernetes 1.24: Volume Expansion Now A Stable Feature"

The idea is that all the post-release blog articles have titles that start Kubernetes 1.24:

**Author:** Hemant Kumar (Red Hat)


Volume expansion was introduced as a alpha feature in Kubernetes 1.8 and it went beta in 1.11 and with Kubernetes 1.24 we are excited to announce general availability(GA)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit)

Suggested change
Volume expansion was introduced as a alpha feature in Kubernetes 1.8 and it went beta in 1.11 and with Kubernetes 1.24 we are excited to announce general availability(GA)
Volume expansion was introduced as a alpha feature in Kubernetes 1.8 and it went beta in 1.11 and with Kubernetes 1.24 we are excited to announce general availability (GA)

@sftim
Copy link
Contributor

sftim commented May 3, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e14991df8353ac5a317d961f4a5bd2b3d7f97f22

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1889495 into kubernetes:main May 3, 2022
@Sea-n
Copy link
Member

Sea-n commented Jun 7, 2022

This single file PR contains 20 commits, maybe we should apply tide/merge-method-squash next time.
cc @sftim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants