Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword dockershim migration recommendation #33016

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Reword dockershim migration recommendation #33016

merged 1 commit into from
Apr 19, 2022

Conversation

Babapool
Copy link
Member

Fixes #32827

This PR:

  • Rewords the Dockershim migration message so as to make a stronger statement about migrating from dockershim after the release of v1.24.

Pages updated: https://github.com/kubernetes/website/blob/main/content/en/docs/tasks/administer-cluster/migrating-from-dockershim/_index.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 18, 2022
@Babapool
Copy link
Member Author

/cc @chrisnegus

@k8s-ci-robot k8s-ci-robot requested a review from chrisnegus April 18, 2022 18:05
@netlify
Copy link

netlify bot commented Apr 18, 2022

Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 98d8be3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/625da809ce99ee0008c66aff
😎 Deploy Preview https://deploy-preview-33016--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reylejano
Copy link
Member

If this PR is to merge to main before the v1.24 release, then there should be a follow-up PR targeting the dev-1.24 branch to update this change accordingly

@chrisnegus
Copy link
Contributor

If this PR is to merge to main before the v1.24 release, then there should be a follow-up PR targeting the dev-1.24 branch to update this change accordingly

Good point! @Babapool I think this PR is fine. But could you open a second PR against dev-1.24 branch to reword "Dockershim will be removed from Kubernetes following the release of v1.24" to something like "Dockershim was removed in Kubernetes release v1.24." Thanks!

Copy link
Contributor

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d3fe800dae352fa5877e9bfd0d2fa0f9ac4a06b

@tengqm
Copy link
Contributor

tengqm commented Apr 19, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisnegus, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3dda62a into kubernetes:main Apr 19, 2022
@Babapool
Copy link
Member Author

If this PR is to merge to main before the v1.24 release, then there should be a follow-up PR targeting the dev-1.24 branch to update this change accordingly

Good point! @Babapool I think this PR is fine. But could you open a second PR against dev-1.24 branch to reword "Dockershim will be removed from Kubernetes following the release of v1.24" to something like "Dockershim was removed in Kubernetes release v1.24." Thanks!

Sure I will open a follow up PR. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reword recommendation to migrate from dockershim
5 participants