Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document per-container termination message limits #33320

Merged
merged 4 commits into from
Jul 31, 2022
Merged

Document per-container termination message limits #33320

merged 4 commits into from
Jul 31, 2022

Conversation

imjasonh
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 29, 2022
@netlify
Copy link

netlify bot commented Apr 29, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d27223e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62e670b896a2180008f93a29
😎 Deploy Preview https://deploy-preview-33320--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Apr 29, 2022

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 29, 2022
divya-mohan0209
divya-mohan0209 previously requested changes May 2, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think citing two examples doesn't add value and only is contributing to redundancy.

content/en/docs/tasks/debug/debug-application/determine-reason-pod-failure.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug/debug-application/determine-reason-pod-failure.md Outdated Show resolved Hide resolved
@divya-mohan0209
Copy link
Contributor

@kubernetes/sig-node-pr-reviews : Please can you sign this off from a tech perspective?

imjasonh and others added 2 commits May 3, 2022 10:08
@imjasonh @divya-mohan0209
Update content/en/docs/tasks/debug/debug-application/determine-reason…
d5e15fe 
…-pod-failure.md

Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
@imjasonh
Remove redundant example.
0f1b35b
@natalisucks
Copy link
Contributor

@kubernetes/sig-node-pr-reviews Looking for your sign-off, thanks!

@zacharysarah
Copy link
Contributor

zacharysarah commented Jun 14, 2022 •
edited
Loading

I've requested review from SIG Node on Slack: https://kubernetes.slack.com/archives/C0BP8PW9G/p1655184285164589

I've also raised awareness of long review times in SIG Docs Slack: https://kubernetes.slack.com/archives/C1J0BPD2M/p1655184616750419

endocrimes
endocrimes reviewed Jul 27, 2022
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
from a technical PoV

small wording nit for clarity, but definitely not really important.

content/en/docs/tasks/debug/debug-application/determine-reason-pod-failure.md Outdated Show resolved Hide resolved
@divya-mohan0209 divya-mohan0209 dismissed their stale review July 27, 2022 15:55

Dismissing stale review

@divya-mohan0209
Copy link
Contributor

Hey @imjasonh , please would you be able to address the nit? We could go ahead with merging after that :)

@imjasonh @endocrimes
Update content/en/docs/tasks/debug/debug-application/determine-reason…
d27223e 
…-pod-failure.md

Co-authored-by: Danielle <dani@builds.terrible.systems>
divya-mohan0209
divya-mohan0209 reviewed Jul 31, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @imjasonh
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209, endocrimes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 34ed5de079bad8efe1a25fadf8726982cfab712b

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0499442 into kubernetes:main Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@endocrimes endocrimes endocrimes left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@divya-mohan0209 divya-mohan0209

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@imjasonh @sftim @divya-mohan0209 @natalisucks @zacharysarah @k8s-ci-robot @endocrimes