Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub PSP docs for 1.25 #33512

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Scrub PSP docs for 1.25 #33512

merged 1 commit into from
Aug 16, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 5, 2022

PodSecurityPolicy admission is dropped in 1.25 in kubernetes/kubernetes#109798

This updates docs for 1.25 to indicate removal and truncates the PSP docs that aren't oriented at migration.

/sig auth
/cc @deads2k @tallclair

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 5, 2022
@netlify
Copy link

netlify bot commented May 5, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit b167938
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62faee5a05a0af000ad95a5b

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 5, 2022
sftim
sftim reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks fine to merge; there are some tweaks that I think would improve it.

Docs LGTM.

content/en/docs/concepts/security/pod-security-admission.md Outdated Show resolved Hide resolved
content/en/docs/concepts/security/pod-security-policy.md Outdated Show resolved Hide resolved
content/en/docs/concepts/security/pod-security-policy.md Outdated Show resolved Hide resolved
content/en/docs/concepts/security/pod-security-policy.md Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/admission-controllers.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/psp-to-pod-security-standards.md Show resolved Hide resolved
content/en/docs/reference/glossary/pod-security-policy.md Outdated Show resolved Hide resolved
content/en/docs/concepts/security/pod-security-policy.md Show resolved Hide resolved
content/en/docs/concepts/security/pod-security-policy.md Outdated Show resolved Hide resolved
content/en/docs/concepts/security/pod-security-policy.md Outdated Show resolved Hide resolved
@liggitt liggitt mentioned this pull request May 19, 2022
Merged
@liggitt
Copy link
Member Author

liggitt commented May 24, 2022

addressed comments in a separate commit

@reylejano
Copy link
Member

/milestone 1.25
/cc @kcmartin

@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Jun 8, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2022
@sftim
Copy link
Contributor

sftim commented Jun 29, 2022

I suggest waiting for #34675 to merge and to appear on the dev-1.25 branch before we approve these changes - that way, there's less risk of missing a detail.

@sftim
Copy link
Contributor

sftim commented Jul 25, 2022

#34675 has merged, so the next resync to dev-1.25 should include that change.

@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f570290cc3e8b45c95eed97a86d69850c9a24b8d

@tallclair tallclair mentioned this pull request Aug 2, 2022
Merged
@sftim sftim mentioned this pull request Aug 2, 2022
Merged
shannonxtreme
shannonxtreme approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@shannonxtreme shannonxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little nits

content/en/docs/concepts/security/pod-security-admission.md Outdated Show resolved Hide resolved
content/en/docs/concepts/security/pod-security-admission.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/admission-controllers.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/psp-to-pod-security-standards.md Outdated Show resolved Hide resolved
@cathchu
Copy link
Contributor

cathchu commented Aug 16, 2022

Hey @liggitt Docs Shadow here 👋 ! There seems to be some conflicts in this branch that need to be resolved before this PR can be merged, as well as some comments that have not been resolved. Please take a look when you can so we can merge!

@liggitt
Copy link
Member Author

liggitt commented Aug 16, 2022

looks like #35618 merged in the meantime... not sure how much of this PR still applies

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2022
@liggitt
Copy link
Member Author

liggitt commented Aug 16, 2022

rebased and applied formatting suggestions

@tengqm
Copy link
Contributor

tengqm commented Aug 16, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 03975568cd0e1b0f4529ec626bbe52867ef92951

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, shannonxtreme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@reylejano
Copy link
Member

/label refactor

@k8s-ci-robot k8s-ci-robot added the refactor Indicates a PR with large refactoring changes e.g. removes files or moves content label Aug 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit c37f7c6 into kubernetes:dev-1.25 Aug 16, 2022
@jglick jglick mentioned this pull request Jan 11, 2023
Closed
@liggitt liggitt deleted the psp branch April 14, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@shannonxtreme shannonxtreme shannonxtreme approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@kcmartin kcmartin Awaiting requested review from kcmartin

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@tengqm tengqm

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. refactor Indicates a PR with large refactoring changes e.g. removes files or moves content sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
1.25
Development

Successfully merging this pull request may close these issues.
8 participants
@liggitt @reylejano @sftim @tallclair @k8s-ci-robot @cathchu @tengqm @shannonxtreme