Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: update unversioned kubelet config map fg info #34159

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Jun 7, 2022

The feature gate goes GA in 1.25 and becomes locked by
default to "enabled". It can be removed from the list.

/kind feature
/sig cluster-lifecycle

(this is targeting 1.25)

xref kubernetes/kubeadm#1582

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 7, 2022
@netlify
Copy link

netlify bot commented Jun 7, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 90dc4e7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62a725507548fd00080a621b

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 7, 2022
@neolit123
Copy link
Member Author

/cc @pacoxu
PTAL

@k8s-ci-robot k8s-ci-robot requested a review from pacoxu June 7, 2022 13:42
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 06cc350e314dd86559fb3c760a3f3dc68febb30f

@reylejano
Copy link
Member

/milestone 1.25
/cc @kcmartin

@k8s-ci-robot k8s-ci-robot requested a review from kcmartin June 8, 2022 02:18
@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Jun 8, 2022
The feature gate goes GA in 1.25 and becomes locked by
default to "enabled".
@neolit123 neolit123 force-pushed the 1.25-update-unversioned-kubelet-config-map-fg-info branch from ebc328f to 90dc4e7 Compare June 13, 2022 11:53
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@k8s-ci-robot k8s-ci-robot requested a review from pacoxu June 13, 2022 11:53
@neolit123 neolit123 requested a review from sftim June 13, 2022 11:54
@sftim sftim dismissed their stale review June 13, 2022 13:00

Sorted

@sftim
Copy link
Contributor

sftim commented Jun 13, 2022

Happy with changes since #34159 (review)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e82446868052c995102b20445202e91dcc2df7c

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey, kcmartin, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1ed3e1f into kubernetes:dev-1.25 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants