-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove list of container runtimes tested with v1.24 #34455
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @chetak123 Could you please update the description to "Fixes #33511" i.e this indicates the issue is resolved. By doing so, whenever a PR gets merged into the |
Should we add it in PR template like
because I think a lot of people may make this mistake |
@@ -13,11 +13,6 @@ To avoid CNI plugin-related errors, verify that you are using or upgrading to a | |||
container runtime that has been tested to work correctly with your version of | |||
Kubernetes. | |||
|
|||
For example, the following container runtimes are being prepared, or have already been prepared, for Kubernetes v1.24: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest having the container runtimes provide a link to a .md support table that will not go stale. Then link from here..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or if there is a location in k8s doc space that provides a "tested" table that would suffice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing completely begs the question.. what has been tested to work... Cheers, Mike
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @mikebrow Are you referring to this type of table https://github.com/containerd/containerd/blob/main/RELEASES.md#kubernetes-support
/retitle Remove list of container runtimes tested with v1.24 |
This PR is against the main branch. @chetak123 you can either:
/hold |
Fixes #33511
I have removed the CNI-pluggin related error example which goes stale in v1.25.
Can we update the containerd example to v1.6.6 and CRI-O to v1.24.1 (latest release) instead of deleting it.