Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Translate the glossary term 'Code Contributor' into Korean #35349

Merged
merged 1 commit into from
Aug 4, 2022
Merged

[ko] Translate the glossary term 'Code Contributor' into Korean #35349

merged 1 commit into from
Aug 4, 2022

Conversation

KimDoubleB
Copy link
Contributor

Resolves #35347

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2022
@k8s-ci-robot k8s-ci-robot requested review from jmyung and pjhwa July 25, 2022 10:55
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 25, 2022
@netlify
Copy link

netlify bot commented Jul 25, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit aa4c446
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62e86e54db6c600008d899de
😎 Deploy Preview https://deploy-preview-35349--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@KimDoubleB KimDoubleB force-pushed the 220725_ko_glossary_term_code_contributor branch from 93af444 to 424a579 Compare July 26, 2022 15:15
@bconfiden2
Copy link
Member

12:15:45 AM: Error: Error building site: "/opt/build/repo/content/zh-cn/docs/tasks/debug/debug-application/debug-service.md:1:1": timed out initializing value. You may have a circular loop in a shortcode, or your site may have resources that take longer to build than the timeout limit in your Hugo config file.

빌드 실패 로그를 확인해보니 zh-cn 문서에서 에러가 발생한 것으로 보이는데, 이게 직접적인 실패의 원인인건지 궁금하네요..! 🥺

@KimDoubleB KimDoubleB force-pushed the 220725_ko_glossary_term_code_contributor branch from 424a579 to 4d4d19f Compare July 27, 2022 15:47
@KimDoubleB
Copy link
Contributor Author

@bconfiden2
오류난 것을 지금 확인했는데요.
최신 dev-1.24-ko.2로 rebase하니 제대로 되네요. 일시적인 이슈였나봅니다.
확인 감사드립니다 🙇🏻‍♂️

jihoon-seo
jihoon-seo reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KimDoubleB 감사합니다!
몇 가지 의견을 남겨 보았습니다. 😊

content/ko/docs/reference/glossary/code-contributor.md
title: 코드 컨트리뷰터
id: code-contributor
date: 2018-04-12
full_link: /ko/docs/community/devel/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

참고:
원문에는 full_link: /docs/community/devel/ 로 되어 있는데,

모두 404 또는 관련내용 없음 입니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇, 이해가 안되서요. 혹시 수정이 필요하다는 말씀이실까요? :)
경로가 조금 이해가 안되긴하더라구요.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 https://github.com/kubernetes/community/tree/master/contributors/devel 여기가 아닐까요..?
정확한 것은 아니지만 kuberenetes/community 저장소 아래에 contributors/devel 이 존재하길래 링크 남겨봅니다!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bconfiden2 여기가 맞을 수도 있겠네요.. ㅎㅎ

content/ko/docs/reference/glossary/code-contributor.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/code-contributor.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/code-contributor.md Outdated Show resolved Hide resolved
@jihoon-seo
Copy link
Member

/assign

@KimDoubleB KimDoubleB force-pushed the 220725_ko_glossary_term_code_contributor branch from 4d4d19f to aa4c446 Compare August 2, 2022 00:22
@jihoon-seo
Copy link
Member

@KimDoubleB @bart2001 @bconfiden2 감사합니다!!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cb7040940c033b5562adc0dcb3277171b132a469

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jihoon-seo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 458f37c into kubernetes:dev-1.24-ko.2 Aug 4, 2022
@jihoon-seo jihoon-seo mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bconfiden2 bconfiden2 bconfiden2 left review comments

@jihoon-seo jihoon-seo jihoon-seo left review comments

@bart2001 bart2001 bart2001 left review comments

@jmyung jmyung Awaiting requested review from jmyung

@pjhwa pjhwa Awaiting requested review from pjhwa

Assignees

@jihoon-seo jihoon-seo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KimDoubleB @bconfiden2 @jihoon-seo @k8s-ci-robot @bart2001