Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CGroupV2 1.25 GA blog post #35452

Merged
merged 7 commits into from
Aug 29, 2022
Merged

CGroupV2 1.25 GA blog post #35452

merged 7 commits into from
Aug 29, 2022

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Jul 27, 2022 •
edited
Loading

Add blog post for cgroupv2 1.25 GA

Enhancement issue: kubernetes/enhancements#2254

See the PR for the cgroup v2 docs here - #35180

Signed-off-by: David Porter david@porter.me

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 27, 2022
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language labels Jul 27, 2022
@bobbypage
Copy link
Member Author

/cc @mrunalp @katcosgrove

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 27, 2022
@bobbypage bobbypage changed the title CGroupV2 GA blog post WIP: CGroupV2 GA blog post Jul 27, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2022
@bobbypage bobbypage marked this pull request as draft July 27, 2022 17:02
@netlify
Copy link

netlify bot commented Jul 27, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 535cf0f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63041c7050266b0008785fa2
😎 Deploy Preview https://deploy-preview-35452--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@katcosgrove
Copy link
Contributor

Hi from the Comms team! Just a reminder that the Ready to Review deadline for feature blogs is Tuesday, August 16. You will also be assigned a publication date. Is there anything we can do to help you right now?

@bobbypage
Copy link
Member Author

Thanks @katcosgrove for the reminder. I will push up a draft by Tuesday as you mentioned. Thanks in advance!

@bobbypage bobbypage changed the title WIP: CGroupV2 GA blog post CGroupV2 GA blog post Aug 16, 2022
@bobbypage bobbypage marked this pull request as ready for review August 16, 2022 04:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim August 16, 2022 04:34
@bobbypage
Copy link
Member Author

I pushed up the draft of the blog post. Please let me know any comments. Thank you!

@bobbypage
CGroupV2 GA blog post
f1ad13a 
Add blog for cgroupv2 GA in 1.25

Signed-off-by: David Porter <david@porter.me>
@bobbypage
Copy link
Member Author

Pushed up latest revision.

/assign @mrunalp

@bobbypage
Copy link
Member Author

/cc @shannonxtreme @katcosgrove

@shannonxtreme
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 01b92126fdc28e4168873875f1703cfafcb0ba01

@mrunalp
Copy link
Contributor

mrunalp commented Aug 17, 2022

/lgtm

@bobbypage bobbypage changed the title CGroupV2 GA blog post CGroupV2 1.25 GA blog post Aug 19, 2022
@bobbypage
Update publication date
e87e224 
* Update publication date
* Bold authors to follow format of other blogs

Signed-off-by: David Porter <david@porter.me>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2022
@bobbypage
Copy link
Member Author

bobbypage commented Aug 19, 2022 •
edited
Loading

Chatted with @katcosgrove on slack and Kat suggested to update publication date to 08-31. Updated date based on that recommendation.

@bobbypage
Copy link
Member Author

/assign @sftim

from sig-docs-blog-owners for approval.

sftim
sftim reviewed Aug 22, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this article.

Please update the path content/en/blog/_posts/2022-08-04-cgroupv2-ga.md to content/en/blog/_posts/2022-08-31-cgroupv2-ga.md

Other than that, it's all nits.

@bobbypage bobbypage force-pushed the cg2-blog branch 2 times, most recently from 64914e8 to 15a3cba Compare August 23, 2022 00:15
@bobbypage @sftim
Apply suggestions from code review
535cf0f 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Signed-off-by: David Porter <david@porter.me>
@bobbypage
Copy link
Member Author

bobbypage commented Aug 23, 2022 •
edited
Loading

Thank you @sftim for reviewing, I updated based on your feedback and renamed the filename based on the publishing date.

@derekwaynecarr
Copy link
Member

@bobbypage the blog post looks great. thanks for the write-up.

@sftim
Copy link
Contributor

sftim commented Aug 25, 2022

Hello Prow. This isn't really blocked, is it?

@afbjorklund
Copy link
Contributor

The examples seem to be missing one container runtime:

Your container runtime supports cgroup v2. For example:
docker v20.10 or later
containerd v1.4 or later
cri-o v1.20 or later

But maybe it was left out on purpose. It's only examples ?

@sftim
Copy link
Contributor

sftim commented Aug 25, 2022

There are more than 3 container runtimes that implement CRI. No need to include Docker Engine IMO (which also doesn't actually implement CRI).

@sftim
Copy link
Contributor

sftim commented Aug 28, 2022

Changes since #35452 (comment) don't need a new tech review.

https://deploy-preview-35452--kubernetes-io-main-staging.netlify.app/blog/2022/08/31/cgroupv2-ga-1-25/ looks good to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5b5da9bb1964aaca8f03f682660c3e39cc23b63

onlydole
onlydole approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@onlydole onlydole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bobbypage and @sftim! This looks good to me!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: onlydole, shannonxtreme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit ade8cd2 into kubernetes:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@onlydole onlydole onlydole approved these changes

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@mrunalp mrunalp Awaiting requested review from mrunalp

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@mrunalp mrunalp

@sftim sftim

@shannonxtreme shannonxtreme

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bobbypage @katcosgrove @shannonxtreme @k8s-ci-robot @mrunalp @derekwaynecarr @sftim @afbjorklund @onlydole