Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Translate the glossary term Reviewer into Korean #35498

Merged
merged 2 commits into from
Aug 7, 2022
Merged

[ko] Translate the glossary term Reviewer into Korean #35498

merged 2 commits into from
Aug 7, 2022

Conversation

gy-ulbak96
Copy link
Contributor

Signed-off-by: gy-ulbak96 rbfl9611@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @gy-ulbak96!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/ko Issues or PRs related to Korean language labels Jul 28, 2022
@k8s-ci-robot k8s-ci-robot requested review from gochist and ianychoi July 28, 2022 12:52
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 28, 2022
@netlify
Copy link

netlify bot commented Jul 28, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 82eb09b
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62edaf3337d70400093275d4
😎 Deploy Preview https://deploy-preview-35498--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Member

This PR is WIP. :)
I am sure the contributor will update the PR and review can be initiated once the contributor update WIP contests.

@gy-ulbak96
Translate the glossary term Reviewer into Korean
92257cf 
Signed-off-by: gy-ulbak96 <rbfl9611@gmail.com>
@gy-ulbak96 gy-ulbak96 force-pushed the feat-dev-1.24-ko.2-gyuri branch from 19651c2 to 92257cf Compare July 30, 2022 10:34
@gy-ulbak96
Copy link
Contributor Author

This PR is WIP. :) I am sure the contributor will update the PR and review can be initiated once the contributor update WIP contests.

Thanks for your reply!
I updated my PR. Please check my PR. :)

jihoon-seo
jihoon-seo reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gy-ulbak96 감사합니다!
Preview: https://deploy-preview-35498--k8s-dev-ko.netlify.app/ko/docs/reference/glossary/?all=true#term-reviewer
/lgtm

content/ko/docs/reference/glossary/reviewer.md Outdated
title: 리뷰어(Reviewer)
id: reviewer
date: 2018-04-12
full_link: /ko
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone's information:
원문은 이 front matter 의 값이 비어 있네요 ㅎㅎ

full_link:

content/ko/docs/reference/glossary/reviewer.md Outdated
tags:
- community
---
프로젝트의 일부 부분에 대해서 코드의 품질과 정확성을 검토하는 사람.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[참고: 원문]

A person who reviews code for quality and correctness on some part of the project.

content/ko/docs/reference/glossary/reviewer.md Outdated

<!--more-->

리뷰어는 코드베이스와 소프트웨어 엔지니어링 원칙에 대해 잘 알고 있다. 리뷰어의 상태는 코드베이스의 일부로 범위가 지정된다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[참고: 원문]

Reviewers are knowledgeable about both the codebase and software engineering principles. Reviewer status is scoped to a part of the codebase.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d647c53b05acdda1f7abd7fd4a0d2deab344eadf

seokho-son
seokho-son reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gy-ulbak96 기여 감사합니다!! :)
간단히 리뷰해보았습니다. 참고하셔서 필요시 PR 업데이트를 부탁드립니다.

content/ko/docs/reference/glossary/reviewer.md Outdated
title: 리뷰어(Reviewer)
id: reviewer
date: 2018-04-12
full_link: /ko
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
full_link: /ko
full_link:

원문에는 해당 링크가 비어 있으므로, 한글 문서에서도 비어 있는 것으로 처리해주시면 됩니다. :)

원문에 링크가 명시되어 있는 경우 해당 링크를 동일하게 기입하면 되는데,
만약 해당 링크에 연결된 영문 문서의 한글 문서가 있다면,
한글 문서로 링크를 변경해주시면 됩니다.

content/ko/docs/reference/glossary/reviewer.md Outdated
tags:
- community
---
프로젝트의 일부 부분에 대해서 코드의 품질과 정확성을 검토하는 사람.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
프로젝트의 일부 부분에 대해서 코드의 품질과 정확성을 검토하는 사람.
프로젝트 일부에 대한 코드를 품질과 정확성 관점에서 검토하는 사람.

원문을 고려하여 수정해 보았습니다. :)

content/ko/docs/reference/glossary/reviewer.md Outdated
date: 2018-04-12
full_link: /ko
short_description: >
프로젝트의 일부 부분에 대해서 코드의 품질과 정확성을 검토하는 사람.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
프로젝트의 일부 부분에 대해서 코드의 품질과 정확성을 검토하는 사람.
프로젝트 일부에 대한 코드를 품질과 정확성 관점에서 검토하는 사람.

content/ko/docs/reference/glossary/reviewer.md Outdated

<!--more-->

리뷰어는 코드베이스와 소프트웨어 엔지니어링 원칙에 대해 잘 알고 있다. 리뷰어의 상태는 코드베이스의 일부로 범위가 지정된다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
리뷰어는 코드베이스와 소프트웨어 엔지니어링 원칙에 대해 잘 알고 있다. 리뷰어의 상태는 코드베이스의 일부로 범위가 지정된다.
리뷰어는 코드베이스와 소프트웨어 엔지니어링 원칙에 대해 잘 알고 있다. 리뷰어의 상태는 코드베이스의 일부로 범위가 한정된다.

은 어떨까요? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵, 고려해주신 부분 기반으로 PR 다시 올리겠습니다~

@seokho-son
Copy link
Member

@gy-ulbak96 님~ 추가 리뷰 의견 확인 부탁드릴게요! :)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2022
@k8s-ci-robot k8s-ci-robot requested a review from jihoon-seo August 6, 2022 00:00
@jihoon-seo
Copy link
Member

@gy-ulbak96 님~~ 리뷰의견 반영까지 해 주셔서 감사합니다~~
현재 이 PR에 2개의 커밋이 속해 있는데요,
이를 1개의 커밋으로 squash 해 주실 수 있을까요? 😊
(Squash 방법은 https://jinnypark9393.github.io/devops/Github_Git_Rebase_Squash/ 를 참고하시면 될 것 같습니다 😊)

@seokho-son
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 7, 2022
@seokho-son
Copy link
Member

@gy-ulbak96 기여 감사합니다!! :)

/lgtm

@seokho-son
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 78686178715c69eefa619df2921776b2ab204fcd

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit c28b8c3 into kubernetes:dev-1.24-ko.2 Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son left review comments

@gochist gochist Awaiting requested review from gochist

@ianychoi ianychoi Awaiting requested review from ianychoi

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo

Assignees

@seokho-son seokho-son

@jihoon-seo jihoon-seo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gy-ulbak96 @k8s-ci-robot @seokho-son @jihoon-seo