Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Translate the glossary term Proxy into Korean #35501

Merged
merged 1 commit into from
Aug 5, 2022
Merged

[ko] Translate the glossary term Proxy into Korean #35501

merged 1 commit into from
Aug 5, 2022

Conversation

BrendenHJH
Copy link
Contributor

Signed-off-by: BrendenHJH brenden0730@gmail.com

fix #35494

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @BrendenHJH!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2022
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 28, 2022
@netlify
Copy link

netlify bot commented Jul 28, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit a3d220c
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62ed1a997e48ee0008a7424a
😎 Deploy Preview https://deploy-preview-35501--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yoonian
Copy link
Contributor

yoonian commented Jul 28, 2022

@BrendenHJH 첫 컨트리뷰션을 감사합니다. 모든 내용을 번역하시고 PR을 보내주시면 좋겠습니다.

@seokho-son
Copy link
Member

This PR is WIP. :)
I am sure the contributor will update the PR and review can be initiated once the contributor update WIP contests.

@BrendenHJH BrendenHJH force-pushed the ko_Translate_the_glossary_term_Proxy branch from 407b0b5 to 2ca2f5b Compare July 29, 2022 13:08
@BrendenHJH
Copy link
Contributor Author

@seokho-son
Glossary > Proxy 모든 부분 번역 완료했습니다~ 확인 부탁드립니다!

yoonian
yoonian reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@yoonian yoonian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrendenHJH Please check my comments. 😓

content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
@jihoon-seo
Copy link
Member

@yoonian 리뷰 감사합니다~~
/assign @yoonian

@seokho-son
Copy link
Member

@BrendenHJH 님~~
조만간 한글화 작업 브랜치의 스위칭(ko.2 -> ko.3)이 진행될 예정입니다.

스위칭 이후에 해당 PR을 처리해도 괜찮지만~
base 브랜치가 변경되면, PR도 rebase 하여 업데이트해야 하므로 다소 번거로울 수 있습니다. ;)

혹시 가능하시면, 리뷰 의견 확인하셔서 PR 업데이트를 부탁 드립니다.

@BrendenHJH BrendenHJH force-pushed the ko_Translate_the_glossary_term_Proxy branch from 2ca2f5b to 0fe4c77 Compare August 5, 2022 09:02
@BrendenHJH
Copy link
Contributor Author

@yoonian
정성스럽게 리뷰해주셔서 감사합니다!
남겨주신 코멘트 바탕으로 해당 내용 수정하였습니다~

@seokho-son
PR 업데이트 완료했습니다~
리마인드해주셔서 정말 감사합니다 :)

@yoonian
Copy link
Contributor

yoonian commented Aug 5, 2022 •
edited
Loading

@BrendenHJH 한번 force push 해주셔야겠는데요?

@BrendenHJH BrendenHJH force-pushed the ko_Translate_the_glossary_term_Proxy branch 2 times, most recently from 5382928 to 19b1e12 Compare August 5, 2022 11:15
@yoonian
Copy link
Contributor

yoonian commented Aug 5, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bb3ddc978fe9cb934323d3f3cb5e33a7b27de771

@BrendenHJH
Copy link
Contributor Author

BrendenHJH commented Aug 5, 2022 •
edited
Loading

@yoonian 혹시 추가로 push를 해야될까요?
(Pending 상태로 메시지를 보니까 approved label이 필요하다고 떠있습니다. 질문하나 드립니다. 혹시 이전에도 push를 다시 요청하신 이유가 해당 label을 추가하시고 prow 봇에게 알리기 위함이 맞을까요? )

@BrendenHJH BrendenHJH force-pushed the ko_Translate_the_glossary_term_Proxy branch from 19b1e12 to 0deeccd Compare August 5, 2022 11:31
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@k8s-ci-robot k8s-ci-robot requested a review from yoonian August 5, 2022 11:31
@yoonian
Copy link
Contributor

yoonian commented Aug 5, 2022 •
edited
Loading

@BrendenHJH

@yoonian 혹시 추가로 push를 해야될까요? (Pending 상태로 메시지를 보니까 approved label이 필요하다고 떠있습니다.)

이젠 추가 리뷰가 있는 것이 아니라면, 다른 작업은 안 하셔도 되어요. 😅
approved 레이블은 approver, lgtm 레이블은 approver 나 reviewer 가 부여합니다.
참고로 pr <-> review <-> lgtm <-> approve <-> merge 이런 단계로 진행됩니다.

그리고 이전에 force push 요청 드렸던 것은 netlify 배포 중에 중단되어서, push 하면 간단히 해결되어서 이야기 드렸던 것입니다.

@BrendenHJH BrendenHJH force-pushed the ko_Translate_the_glossary_term_Proxy branch from 0deeccd to 8c8a62d Compare August 5, 2022 11:31
@seokho-son
Copy link
Member

@BrendenHJH
푸시는 다시하실 필요 없습니다. :)
tide에 pending은 아직 PR이 (자동으로) 머지되는 조건을 만족시키지 못하고 있다는 뜻이고

이 머지의 조건이 lgtm 레이블과 approved 레이블입니다. :) 결국 리뷰가 완료되고 승인까지 떨어져야 PR이 머지될 수 있음을 의미합니다!

기존에 커밋 푸시를 요청하셨던 이유는 netlify가 PR이 올라오거나 커밋이 추가되면 빌드 테스트 및 프리뷰 생성을 진행하는데. 이 단계에서 빌드가 성공적으로 수행하지 않아서 푸시를 요청하셨을고예요. 지금은 문제 없어 보입니다! :)

@BrendenHJH
Copy link
Contributor Author

@BrendenHJH

@yoonian 혹시 추가로 push를 해야될까요? (Pending 상태로 메시지를 보니까 approved label이 필요하다고 떠있습니다.)

이젠 추가 리뷰가 있는 것이 아니라면, 다른 작업은 안 하셔도 되어요. 😅 approved 나 lgtm 등의 레이블은 approver 나 reviewer 가 부여합니다. 참고로 pr <-> review <-> lgtm <-> approve <-> merge 이런 단계로 진행됩니다.

그리고 이전에 force push 요청 드렸던 것은 netlify 배포 중에 중단되어서, push 하면 간단히 해결되어서 이야기 드렸던 것입니다.

@BrendenHJH BrendenHJH closed this Aug 5, 2022
@BrendenHJH BrendenHJH deleted the ko_Translate_the_glossary_term_Proxy branch August 5, 2022 11:33
@BrendenHJH BrendenHJH restored the ko_Translate_the_glossary_term_Proxy branch August 5, 2022 11:33
@yoonian
Copy link
Contributor

yoonian commented Aug 5, 2022 •
edited
Loading

@BrendenHJH 혹시 다시 PR 보내시려나요? 걍 재 오픈해도 될듯 한데요?!
머지 되기 전까지는 브랜치는 유지하셔야 합니다.

@seokho-son seokho-son reopened this Aug 5, 2022
@yoonian
Copy link
Contributor

yoonian commented Aug 5, 2022

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bb3ddc978fe9cb934323d3f3cb5e33a7b27de771

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@BrendenHJH
Copy link
Contributor Author

@yoonian
제가 코멘트 달려다가 취소했는데 모르고...닫아버렸네요...

@seokho-son
다시 reopen해주셔서 감사합니다 :)

@seokho-son
Copy link
Member

@BrendenHJH
말씀드렸던 netlify의 빌드가 성공하면,
#35501 (comment)
이렇게 netlify가 프리뷰의 링크가 포함된 코멘트를 달아줍니다. :)

프리뷰 주소는 아래와 같습니다.
https://deploy-preview-35501--k8s-dev-ko.netlify.app/ko/docs/reference/glossary/?all=true#term-proxy

보통 리뷰어와 승인자는 해당 프리뷰를 확인합니다.
특히 승인자는 PR 승인 이전에 프리뷰를 확인하고 문제가 없는지 살펴봅니다.

seokho-son
seokho-son reviewed Aug 5, 2022
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrendenHJH
추가적으로 리뷰를 수행해보았습니다. :)
의견 참고하셔서, PR 업데이트를 부탁드립니다.

작업하시며, 커밋을 스쿼싱(하나로 정리)해주셔도 좋을 것 같습니다.

참고로, git commit --amend 하면 가장 최근 커밋에 수정사항을 덮어쓰기합니다. :)

content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/proxy.md Outdated Show resolved Hide resolved
@BrendenHJH
Translate the glossary term Proxy into Korean
a3d220c 
Signed-off-by: BrendenHJH <brenden0730@gmail.com>
@BrendenHJH BrendenHJH force-pushed the ko_Translate_the_glossary_term_Proxy branch from 8c8a62d to a3d220c Compare August 5, 2022 13:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@BrendenHJH
Copy link
Contributor Author

@seokho-son
주신 의견 참고하여 PR 업데이트 진행했습니다.

알려주셨던 git commit --amend 를 활용하여 가장 최근 커밋에 수정사항을 덮어쓰는 방법으로 작업 진행했습니다.
혹시 커밋을 스쿼싱(하나로 정리)하는 작업이 필요할지 추가로 여쭤봅니다~

@jihoon-seo
Copy link
Member

@BrendenHJH 현재 이 PR에 포함된 커밋이 이미 1개라서, squash 작업은 하지 않으셔도 되겠습니다~~

@yoonian
Copy link
Contributor

yoonian commented Aug 5, 2022

/lgtm

@seokho-son
Copy link
Member

Thank you all !!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@seokho-son
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cdd6f70baabc75ea22891ed1c4d67935a3e42b78

@k8s-ci-robot k8s-ci-robot merged commit 0a70b70 into kubernetes:dev-1.24-ko.2 Aug 5, 2022
@jihoon-seo jihoon-seo mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son left review comments

@yoonian yoonian Awaiting requested review from yoonian

Assignees

@seokho-son seokho-son

@yoonian yoonian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BrendenHJH @k8s-ci-robot @yoonian @seokho-son @jihoon-seo