Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the health checking link #35678

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

vaibhav2107
Copy link
Member

Corrected the text link for health-cheking.md under grpc.service

Service is the name of the service to place in the gRPC HealthCheckRequest (see https://github.com/grpc/grpc/blob/master/doc/health-checking.md).

If this is not specified, the default behavior is defined by gRPC.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 3, 2022
@netlify
Copy link

netlify bot commented Aug 3, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit da39cd1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62eaa15a2786f80009fe0f99
😎 Deploy Preview https://deploy-preview-35678--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vaibhav2107
Copy link
Member Author

Hi @daminisatya , @rajeshdeshpande02 ,
Please have a look

Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the link is broken if no space before ).

https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#Probe

@Sea-n
Copy link
Member

Sea-n commented Aug 4, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2dcc608a25e26836fe2bd169cbad985cd9ceb6b4

@vaibhav2107
Copy link
Member Author

Thanks @Sea-n for reviewing

@reylejano
Copy link
Member

Confirmed that the added space makes the link work
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit b8176a1 into kubernetes:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants