Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected param shortcode. #35725

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Corrected param shortcode. #35725

merged 2 commits into from
Aug 10, 2022

Conversation

Shubham82
Copy link
Contributor

This PR corrects the param shortcode in Upgrading Windows nodes task.

Fixes: #35686

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 5, 2022
@Shubham82 Shubham82 mentioned this pull request Aug 5, 2022
Closed
@Shubham82
Copy link
Contributor Author

PTAL

@netlify
Copy link

netlify bot commented Aug 5, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ed9425a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62f0a4be2ed4530008733e08
😎 Deploy Preview https://deploy-preview-35725--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim
sftim reviewed Aug 5, 2022
View reviewed changes
content/en/docs/tasks/administer-cluster/kubeadm/upgrading-windows-nodes.md Outdated
@@ -32,7 +32,7 @@ upgrade the control plane nodes before upgrading your Windows nodes.

1. From the Windows node, upgrade kubeadm:

```powershell
```shell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 this isn't right: the code is PowerShell.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @sftim for taking look at this.

If we want to keep the code as Powershell so then we can put the URL (https://dl.k8s.io/{{< param "fullversion" >}}/bin/windows/amd64/...) into the inverted commas (" ") will resolve this issue.

look like this:

# replace v1.24.0 with your desired version
curl.exe -Lo <path-to-kubeadm.exe>  "https://dl.k8s.io/v1.24.0/bin/windows/amd64/kubeadm.exe"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it seems good?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. You could try quoting the URL, that looks like it'd be valid PowerShell.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. You could try quoting the URL, that looks like it'd be valid PowerShell.

I will update it soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed the comment.
PTAL!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use single quotes in powershell too.
The currently changes also work

@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c16635385712296578f0a3dc6fa6107bece946ab

@marosset
Copy link
Contributor

marosset commented Aug 8, 2022

/lgtm

@jihoon-seo
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 10, 2022
@jihoon-seo
Copy link
Member

Preview: https://deploy-preview-35725--kubernetes-io-main-staging.netlify.app/docs/tasks/administer-cluster/kubeadm/upgrading-windows-nodes/

I checked and confirm that the command

curl.exe -Lo <path-to-kubeadm.exe>  "https://dl.k8s.io/v1.24.0/bin/windows/amd64/kubeadm.exe"

works with Windows PowerShell.
/lgtm

@natalisucks
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7bad15b into kubernetes:main Aug 10, 2022
mccormickt pushed a commit to mccormickt/k8s-website that referenced this pull request Aug 10, 2022
@Shubham82 @mccormickt
Corrected param shortcode. (kubernetes#35725)
179f76d 
* Corrected param shortcode.

* Quote the URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@marosset marosset marosset left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@marosset marosset

@jihoon-seo jihoon-seo

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"param" shortcode is not working in some cases
7 participants
@Shubham82 @reylejano @k8s-ci-robot @marosset @jihoon-seo @natalisucks @sftim