Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] Updated content-guide.md & diagram-guide.md #35764

Merged
merged 1 commit into from
Aug 8, 2022
Merged

[zh-cn] Updated content-guide.md & diagram-guide.md #35764

merged 1 commit into from
Aug 8, 2022

Conversation

windsonsea
Copy link
Member

@windsonsea windsonsea commented Aug 7, 2022 •
edited
Loading

Updated text.

content/zh-cn/docs/contribute/style/content-guide.md
content/zh-cn/docs/contribute/style/diagram-guide.md

Preview: https://deploy-preview-35764--kubernetes-io-main-staging.netlify.app/zh-cn/docs/contribute/style/content-guide/

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2022
@k8s-ci-robot k8s-ci-robot requested review from Sea-n and tengqm August 7, 2022 12:33
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 7, 2022
@windsonsea windsonsea changed the title [updated] content-guide.md & diagram-guide.md [zh-cn] Updated content-guide.md & diagram-guide.md Aug 7, 2022
@netlify
Copy link

netlify bot commented Aug 7, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9db1d7c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62efc393dae5440009356a9b
😎 Deploy Preview https://deploy-preview-35764--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Aug 7, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2022
Sea-n
Sea-n reviewed Aug 7, 2022
View reviewed changes
Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.

content/zh-cn/docs/contribute/style/content-guide.md
Comment on lines -87 to +88
这里的 Kubernetes 项目指的是 [kubernetes](https://github.com/kubernetes) 和
[kubernetes-sigs](https://github.com/kubernetes-sigs) GitHub 组织
下的项目。
这里的 Kubernetes 项目指的是 [Kubernetes](https://github.com/kubernetes) 和
[Kubernetes SIGs](https://github.com/kubernetes-sigs) GitHub 组织下的那些项目。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The English text is still kubernetes-sigs, not Kubernetes SIGs.

But I think it's a good change for Mandarin.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it might be better to keep the text same as the linked title here.

content/zh-cn/docs/contribute/style/content-guide.md Outdated Show resolved Hide resolved
content/zh-cn/docs/contribute/style/diagram-guide.md
你需要考虑你的目标受众。除了一些有经验的 K8s 用户外，你还会遇到很多刚接触
你需要考虑你的目标受众。除了一些有经验的 Kubernetes 用户外，你还会遇到很多刚接触
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The English text is K8s instead of Kubernetes, not sure which is better here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this small para, a reader can easily find 3 Kubernetes and 1 k8s, which is suggested to be consistent. If on different screens, it might be another case because few people may notice this minor inconsistency.

content/zh-cn/docs/contribute/style/diagram-guide.md Outdated Show resolved Hide resolved
@Sea-n
Copy link
Member

Sea-n commented Aug 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5b47e008ae730f5502044b2793c62f8880fb39f0

@k8s-ci-robot k8s-ci-robot merged commit bb5e0b3 into kubernetes:main Aug 8, 2022
@windsonsea windsonsea deleted the conguide branch August 9, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sea-n Sea-n Sea-n left review comments

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@Sea-n Sea-n

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@windsonsea @tengqm @k8s-ci-robot @Sea-n