Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] Sync install-kubeadm.md #35831

Merged
merged 1 commit into from
Aug 11, 2022
Merged

[zh-cn] Sync install-kubeadm.md #35831

merged 1 commit into from
Aug 11, 2022

Conversation

Sea-n
Copy link
Member

@Sea-n Sea-n commented Aug 10, 2022 •
edited
Loading

There are a paragraph deleted in upstream but not synced yet.

Solve IsSet with "invalid" (<nil>) warning (2 of 3)

Put comment into {{< table >}} shortcode, not sure it will work or not.

The Preview seems looks good:
https://deploy-preview-35831--kubernetes-io-main-staging.netlify.app/zh-cn/docs/setup/production-environment/tools/kubeadm/install-kubeadm/

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2022
@k8s-ci-robot k8s-ci-robot requested review from chenxuc and tengqm August 10, 2022 02:33
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 10, 2022
@netlify
Copy link

netlify bot commented Aug 10, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 35831ef
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62f4798561170f000a1ee972
😎 Deploy Preview https://deploy-preview-35831--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

windsonsea
windsonsea reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A style issue to read easily.

content/zh-cn/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md Outdated
* 集群中的所有机器的网络彼此均能相互连接（公网和内网都可以）
发行版以及一些不提供包管理器的发行版提供通用的指令。
* 每台机器 2 GB 或更多的 RAM（如果少于这个数字将会影响你应用的运行内存）。
* 2 CPU 核心或更多。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* 2 CPU 核心或更多。
* 2 核或更多的 CPU。

Similar to the previous line: 2 GB 或更多的 RAM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "CPU 4 核心以上"?
It's weird for me to use "or more CPU", it should be "or more (CPU) cores".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I know it's double standards, but "or more RAM" is acceptable for me.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPU 2 核心及以上

yes, it's all right.

@tengqm
Copy link
Contributor

tengqm commented Aug 10, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@windsonsea windsonsea mentioned this pull request Aug 11, 2022
Closed
@Sea-n Sea-n force-pushed the fix-hugo-table-zh branch from 35831ab to 35831cd Compare August 11, 2022 01:56
tengqm
tengqm reviewed Aug 11, 2022
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Found a nit, not directly related.

content/zh-cn/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md Outdated
Comment on lines 29 to 30
有关在执行此安装过程后如何使用 kubeadm 创建集群的信息，请参见
[使用 kubeadm 创建集群](/zh-cn/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/)页面。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
有关在执行此安装过程后如何使用 kubeadm 创建集群的信息，请参见
[使用 kubeadm 创建集群](/zh-cn/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/)页面。
有关在执行此安装过程后如何使用 kubeadm 创建集群的信息，
请参见[使用 kubeadm 创建集群](/zh-cn/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/)。

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sea-n Sea-n force-pushed the fix-hugo-table-zh branch from 35831cd to 35831ef Compare August 11, 2022 03:36
@Sea-n Sea-n force-pushed the fix-hugo-table-zh branch from 35831ef to 35831ef Compare August 11, 2022 03:37
@windsonsea
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3ced6ccf2826e8132df3a4a5a0bc40631f87db5

@k8s-ci-robot k8s-ci-robot merged commit 06b7c74 into kubernetes:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windsonsea windsonsea windsonsea left review comments

@tengqm tengqm tengqm left review comments

@chenxuc chenxuc Awaiting requested review from chenxuc

Assignees

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sea-n @tengqm @k8s-ci-robot @windsonsea