Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Translate /docs/setup/best-practices/enforcing-pod-security-stan… #36726

Conversation

NayeonKeum
Copy link
Contributor

…dards/ into Korean

Signed-off-by: Nayeon Keum rmaskdus0208@gmail.com

Issue: #35919

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/ko Issues or PRs related to Korean language labels Sep 10, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 10, 2022
@netlify
Copy link

netlify bot commented Sep 10, 2022

Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit d5ea5c7
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/631ffb3edf34f10008a0a433
😎 Deploy Preview https://deploy-preview-36726--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NayeonKeum NayeonKeum force-pushed the feat-dev-1.24-ko.3-pod-security branch from 168d2fd to 8ad9d35 Compare September 12, 2022 11:53
@seokho-son
Copy link
Member

/assign

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NayeonKeum
Thank you for the contribution.
Please check the review comments below. :)

…dards/ into Korean

Signed-off-by: Nayeon Keum <rmaskdus0208@gmail.com>
@NayeonKeum
Copy link
Contributor Author

Thank you for your reviews! I applied them all :)

@NayeonKeum NayeonKeum force-pushed the feat-dev-1.24-ko.3-pod-security branch from 8ad9d35 to d5ea5c7 Compare September 13, 2022 03:38
@seokho-son
Copy link
Member

Thank you @NayeonKeum :)
Looks great !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cae125e8edb9c6a5a7636e7b2c902c8ac83a893d

@seokho-son
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit becbac6 into kubernetes:dev-1.24-ko.3 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants