Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] Fixes Broken Link #36936

Merged
merged 1 commit into from
Oct 2, 2022
Merged

[zh-cn] Fixes Broken Link #36936

merged 1 commit into from
Oct 2, 2022

Conversation

amolmote
Copy link
Member

Signed-off-by: amolmote amolmote201@gmail.com

Fixes #36910

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2022
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Sep 21, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 21, 2022
@netlify
Copy link

netlify bot commented Sep 21, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e4c370d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6339a5be26b8b600084a0055
😎 Deploy Preview https://deploy-preview-36936--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Sea-n
Copy link
Member

Sea-n commented Sep 23, 2022

I think it's better to fix content/en/docs/reference/glossary/code-contributor.md instead.

@amolmote
Copy link
Member Author

I already fix it

@Sea-n
Copy link
Member

Sea-n commented Sep 24, 2022

Oh, sorry for my local branch missed PR #36881.

You are right, you already fixed this in English version.

@Sea-n
Copy link
Member

Sea-n commented Sep 24, 2022

Please update line 18 as well, thanks!

@tengqm
Copy link
Contributor

tengqm commented Sep 30, 2022

@amolmote Please consider address the feedback.

@amolmote
Copy link
Member Author

Will do it soon. I thought it's only a comment so I need not update there also.

@amolmote
Copy link
Member Author

Can I remove the unwanted comments because it's has no use

@tengqm
Copy link
Contributor

tengqm commented Oct 1, 2022

@amolmote Line 18 should be sync'ed with the English version as well. Although it is in comments. We compare these commented out paragraphs against the English version to find diffs.

@amolmote
Copy link
Member Author

amolmote commented Oct 1, 2022

Ok will push the new changes by squashing commits.

@amolmote
Copy link
Member Author

amolmote commented Oct 1, 2022

done @tengqm

Sea-n
Sea-n reviewed Oct 2, 2022
View reviewed changes
Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4020a627c75b0d849987d3884dd8efee18bec877

tengqm
tengqm reviewed Oct 2, 2022
View reviewed changes
content/zh-cn/docs/reference/glossary/code-contributor.md Outdated
@@ -15,7 +15,7 @@ tags:
title: Code Contributor
id: code-contributor
date: 2018-04-12
full_link: /docs/community/devel/
full_link: https://github.com/kubernetes/community/tree/master/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 18 should be same as line 5, right?

@amolmote
Copy link
Member Author

amolmote commented Oct 2, 2022

Yes absolutely @tengqm, my bad correct it asap.

@amolmote
[zh-cn] Fixes Broken Link
e4c370d 
Signed-off-by: amolmote <amolmote201@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2022
@tengqm
Copy link
Contributor

tengqm commented Oct 2, 2022

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4e2d4132c0506aa63a7b92de49c284c05622b522

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 55bbd4b into kubernetes:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

@Sea-n Sea-n Awaiting requested review from Sea-n

Assignees

@tengqm tengqm

@Sea-n Sea-n

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[zh-cn] Need to update the code-contribution.md with full link
4 participants
@amolmote @Sea-n @tengqm @k8s-ci-robot