Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate scheduler nodeInclusionPolicy to beta #37688

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Graduate scheduler nodeInclusionPolicy to beta #37688

merged 1 commit into from
Nov 8, 2022

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Nov 3, 2022

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Nov 3, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 3, 2022
@netlify
Copy link

netlify bot commented Nov 3, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit d8e7a7a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6363a52d32ddf500092e83f0

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Nov 3, 2022

/sig scheduling
/hold for kubernetes/kubernetes#113500

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Nov 3, 2022
@kerthcet kerthcet mentioned this pull request Nov 3, 2022
Open
12 tasks
@kerthcet
Feat: graduate NodeInclusionPolicy to beta
d8e7a7a 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the feat/graduate-nodeInclusionPoplicy branch from 2842330 to d8e7a7a Compare November 3, 2022 11:25
@tengqm
Copy link
Contributor

tengqm commented Nov 4, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5906a8c8f9bbc8b0564de337ca7641d5f3e8248

@kerthcet
Copy link
Member Author

kerthcet commented Nov 8, 2022

/hold cancel
As related PRs are merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Nov 8, 2022

cc @tengqm @sftim for approval.

@tengqm
Copy link
Contributor

tengqm commented Nov 8, 2022

All upstream code have been merged.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit b0fa875 into kubernetes:dev-1.26 Nov 8, 2022
@kerthcet kerthcet deleted the feat/graduate-nodeInclusionPoplicy branch November 8, 2022 07:46
@Sea-n Sea-n mentioned this pull request Nov 30, 2022
Closed
@kerthcet kerthcet restored the feat/graduate-nodeInclusionPoplicy branch March 31, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@sftim sftim Awaiting requested review from sftim

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
3 participants
@kerthcet @tengqm @k8s-ci-robot