Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events beta docs update #37830

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Events beta docs update #37830

merged 2 commits into from
Nov 29, 2022

Conversation

ardaguclu
Copy link
Member

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Nov 10, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 10, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 10, 2022
@netlify
Copy link

netlify bot commented Nov 10, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 1c26c7b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/63844589f75586000878d479

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 10, 2022
@ardaguclu ardaguclu mentioned this pull request Nov 10, 2022
Closed
12 tasks
@krol3
Copy link
Contributor

krol3 commented Nov 15, 2022

CC @mickeyboxell

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 16, 2022
@ardaguclu ardaguclu marked this pull request as ready for review November 16, 2022 06:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2022
@ardaguclu
Copy link
Member Author

ardaguclu commented Nov 16, 2022 •
edited
Loading

This is my first change on kubernetes/website and I'm not sure changing kubectl-commands in here https://github.com/kubernetes/website/blob/ed0578b98e4756eb17b4b29c6d6543230066731e/static/docs/reference/generated/kubectl/kubectl-commands.html or is this html autogenerated?

Other than that, since this PR promotion of events command from alpha to beta. I added it into command list and hope that it is sufficient.

/cc @soltysh

@k8s-ci-robot k8s-ci-robot requested a review from soltysh November 16, 2022 06:44
soltysh
soltysh approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from tech pov
@ardaguclu you need approval from sig-docs

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4ac84b2c9cd67ad5abe5f6c5274ef0f477e8448b

@krol3
Copy link
Contributor

krol3 commented Nov 28, 2022

Hi @ardaguclu! This PR needs a doc review by Mon Nov 28th to get this into the release. Please reach out to required SIGs to get their review. Thank you!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2022
@k8s-ci-robot k8s-ci-robot requested a review from soltysh November 28, 2022 05:22
@ardaguclu
Copy link
Member Author

@tengqm thanks for review. Updated, could you PTAL?

@sftim
Copy link
Contributor

sftim commented Nov 28, 2022

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Nov 28, 2022
sftim
sftim reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d07a65c3a6dc02de32c452702abbbe4008d0c9c7

@krol3
Copy link
Contributor

krol3 commented Nov 28, 2022

@soltysh can you approve this PR ?

@soltysh
Copy link
Contributor

soltysh commented Nov 29, 2022

@soltysh can you approve this PR ?

approval has to be from sig-docs, @sftim can you make the honors, this is 👍 from sig-cli pov

@tengqm
Copy link
Contributor

tengqm commented Nov 29, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3f44ffc into kubernetes:dev-1.26 Nov 29, 2022
@ardaguclu ardaguclu deleted the events-doc-update branch November 29, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@tengqm tengqm tengqm left review comments

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@krousey krousey Awaiting requested review from krousey

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@soltysh soltysh

@tengqm tengqm

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
6 participants
@ardaguclu @krol3 @k8s-ci-robot @sftim @soltysh @tengqm