Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Remove instruction to use iptables-legacy #38708

Merged
merged 1 commit into from
Jan 18, 2023
Merged

[ja] Remove instruction to use iptables-legacy #38708

merged 1 commit into from
Jan 18, 2023
+0 −26

Conversation

grainrigi
Copy link
Contributor

As reverted in 8830000, switching to iptables-legacy is no longer required.

@grainrigi
[ja] Remove instruction to use iptables-legacy
0140099 
As reverted in 8830000, switching to iptables-legacy is no longer required.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 31, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Dec 31, 2022
@k8s-ci-robot k8s-ci-robot requested a review from kakts December 31, 2022 07:39
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 31, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @grainrigi!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 31, 2022
@netlify
Copy link

netlify bot commented Dec 31, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0140099
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63afe74a2c83510008a35a4a
😎 Deploy Preview https://deploy-preview-38708--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 31, 2022
@grainrigi
Copy link
Contributor Author

/easycla

@grainrigi
Copy link
Contributor Author

It's been already 2 weeks but still no comments/reviews.
What is the current status of this PR?

@atoato88
Copy link
Contributor

/lgtm

Thank you for the notification.
It's LGTM.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 177fad08c32f926d9669a002076e121e622ec6e4

@atoato88
Copy link
Contributor

For other reviewers:

  • You can read some background about 8830000 commit from here.

@atoato88
Copy link
Contributor

/assign @nasa9084

nasa9084
nasa9084 reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you~
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6fdc077 into kubernetes:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nasa9084 nasa9084 nasa9084 left review comments

@atoato88 atoato88 Awaiting requested review from atoato88

@kakts kakts Awaiting requested review from kakts

Assignees

@atoato88 atoato88

@nasa9084 nasa9084

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grainrigi @k8s-ci-robot @atoato88 @nasa9084