statefulset: explicit apiVersion and kind for volumeClaimTemplates

[sathieu]

The conversion introduced by kubernetes/kubernetes#87706 caused ServerSide-apply to generate a diff when the applied volumeClaimTemplates item has no apiVersion or kind .

This PR recommends setting apiVersion and kind .

See argoproj/argo-cd#11143.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kbhawkey for approval by writing /assign @kbhawkey in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @sathieu!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[netlify]

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	8c1133e
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63c7080174bf340008edeb21
😎 Deploy Preview	https://deploy-preview-38981--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[lavalamp]

...or is SSA doing something wrong? cc @apelisse to check?

[sathieu]

@lavalamp You are right, and I don't see why SSA is going thru conversion (we are using apps/v1 StatefulSet).

[sathieu]

Anyone having a idea how to fix diff in ServerSideApply with volumeClaimTemplates?

Ping @liggitt @wojtek-t 🙇

[apelisse]

I mostly understand what's going on but a few details are still a little fuzzy. What are some minimal steps to reproduce so I can take a better look? Thanks.

[sathieu]

It looks like the issue is coming from the way ArgoCD uses SSA (argoproj/argo-cd#11143 (comment)). Closing PR.