Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Translate concepts/scheduling-eviction/pod-priority-preemption/ into Japanese #39105

Merged
merged 3 commits into from
Feb 6, 2023
Merged

[ja] Translate concepts/scheduling-eviction/pod-priority-preemption/ into Japanese #39105

merged 3 commits into from
Feb 6, 2023

Conversation

Gekko0114
Copy link
Member

@Gekko0114 Gekko0114 commented Jan 25, 2023 •
edited
Loading

Translated concepts/scheduling-eviction/pod-priority-preemption/ into Japanese.

I found that previously concepts/configuration/pod-priority-preemption was moved to concepts/scheduling-eviction/pod-priority-preemption.
So first I moved ja/docs/concepts/configuration/pod-priority-preemption to ja/docs/concepts/scheduling-eviction/pod-priority-preemption. Then I updated some points.

This is my first time contributing to this repository. So if there are any mistakes, please let me know.
Thanks,

Close #39104

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Gekko0114!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot requested review from kakts and t-inu January 25, 2023 15:30
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 25, 2023
@netlify
Copy link

netlify bot commented Jan 25, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 20461d6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63dbbc012af1f20009e64d5f
😎 Deploy Preview https://deploy-preview-39105--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Gekko0114 Gekko0114 changed the title Translate concepts/scheduling-eviction/pod-priority-preemption/ into Japanese [ja] Translate concepts/scheduling-eviction/pod-priority-preemption/ into Japanese Jan 28, 2023
@Gekko0114
Copy link
Member Author

Hi @kakts @t-inu,

Could you review my PR?
This is my first PR for this repo. If I did a wrong thing, please let me know.
Thanks in advance,

t-inu
t-inu reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thanks for your contribution.
I left 2 comments, please check.

content/ja/docs/concepts/scheduling-eviction/pod-priority-preemption.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/scheduling-eviction/pod-priority-preemption.md Show resolved Hide resolved
@Gekko0114
Copy link
Member Author

Thank you so much for your detailed review. I will revise it and push again.

@Gekko0114
Copy link
Member Author

Hi @kakts @t-inu,

Thank you so much for your comments. I fixed it.
Please review my PR again.

Thanks,

t-inu
t-inu approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7f3e1db97fd87384d8cb0460a6b50efab7d11d80

@t-inu
Copy link
Member

t-inu commented Feb 2, 2023

/assign @nasa9084
Could you check this PR?

nasa9084
nasa9084 reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution 🎉
I left small suggest 🙇

content/ja/docs/concepts/scheduling-eviction/pod-priority-preemption.md Outdated Show resolved Hide resolved
@Gekko0114 @nasa9084
Update content/ja/docs/concepts/scheduling-eviction/pod-priority-pree…
20461d6 
…mption.md

Co-authored-by: nasa9084 <nasa9084@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
@Gekko0114
Copy link
Member Author

Hi @kakts @t-inu @nasa9084,

Thanks for your comments. I fixed your review comments. So could you approve this PR?
Thanks,

t-inu
t-inu approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ffe908bf8166cb3956e70efc41ab7e47ad83e3dd

@nasa9084
Copy link
Member

nasa9084 commented Feb 6, 2023

/approve
Thank you for your contribution!!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084, t-inu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit ebea533 into kubernetes:main Feb 6, 2023
@Gekko0114 Gekko0114 mentioned this pull request Oct 2, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-inu t-inu t-inu approved these changes

@kakts kakts Awaiting requested review from kakts

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

@nasa9084 nasa9084

@t-inu t-inu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate concepts/scheduling-eviction/pod-priority-preemption/ into Japanese
4 participants
@Gekko0114 @k8s-ci-robot @t-inu @nasa9084