Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hello-minikube.md #39190

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Update hello-minikube.md #39190

merged 2 commits into from
Feb 6, 2023

Conversation

Jun10ng
Copy link
Contributor

@Jun10ng Jun10ng commented Jan 31, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 31, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2023
@netlify
Copy link

netlify bot commented Jan 31, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 62ad84a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63da1a30e90db90008f6b39b
😎 Deploy Preview https://deploy-preview-39190--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kundan2707
kundan2707 reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jun10ng Jun10ng requested review from tengqm and removed request for shannonxtreme and reylejano February 1, 2023 07:52
@tengqm
Copy link
Contributor

tengqm commented Feb 1, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 482dab07e4b1d3f3ba1673914d5fff644ec178e9

chrisnegus
chrisnegus reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about Katacoda.

content/en/docs/tutorials/hello-minikube.md
@@ -90,14 +90,17 @@ tutorial has only one Container. A Kubernetes
Pod and restarts the Pod's Container if it terminates. Deployments are the
recommended way to manage the creation and scaling of Pods.

1. Katacoda environment only: At the top of the terminal pane, click the plus sign, and then click open a new terminal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Katacoda shut down? Is there some other way to run Katacoda?

Copy link
Contributor Author

@Jun10ng Jun10ng Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Katacoda is working still.
The following is what happened to me:
At the selection of create a deployment, user's terminal will be block on $ minikube dashboard, so we need reminder users to open a new terminal.

Did you mean we can run minikube dashboard with & ?

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit f948d81 into kubernetes:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kundan2707 kundan2707 kundan2707 left review comments

@chrisnegus chrisnegus chrisnegus left review comments

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jun10ng @tengqm @k8s-ci-robot @reylejano @chrisnegus @kundan2707