Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for Beta feature PodSchedulingReadiness #39773

Merged

Conversation

Huang-Wei
Copy link
Member

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 3, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kbhawkey March 3, 2023 17:42
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 3, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim March 3, 2023 17:42
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 3, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

@@ -164,7 +164,8 @@ For a reference to old feature gates that are removed, please refer to
| `PodDisruptionConditions` | `false` | Alpha | 1.25 | 1.25 |
| `PodDisruptionConditions` | `true` | Beta | 1.26 | |
| `PodHasNetworkCondition` | `false` | Alpha | 1.25 | |
| `PodSchedulingReadiness` | `false` | Alpha | 1.26 | |
| `PodSchedulingReadiness` | `false` | Alpha | 1.26 | 1.27 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `PodSchedulingReadiness` | `false` | Alpha | 1.26 | 1.27 |
| `PodSchedulingReadiness` | `false` | Alpha | 1.26 | 1.26 |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Tim. Updated.

@Huang-Wei Huang-Wei force-pushed the 1.27/PodSchedulingReadiness-beta branch from 358c8b0 to fc01961 Compare March 6, 2023 17:02
@tengqm
Copy link
Contributor

tengqm commented Mar 9, 2023

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eaae7a5a9eb74ee18142ef08d8f063f9e9575c09

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit d3979d5 into kubernetes:dev-1.27 Mar 9, 2023
@Huang-Wei Huang-Wei deleted the 1.27/PodSchedulingReadiness-beta branch February 21, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants