-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add doc for ServiceNodePortStaticSubrange #39850
Conversation
|
56e08cf
to
808ee08
Compare
/remove-language zh |
@xuzhenglun It looks like this is marked as a Blog rather than a Docs PR. Could you rename the PR? When you're ready, populate your placeholder PR with feature documentation and change the state of the PR from draft to ready for review. The official Docs deadline for PRs to be ready for review is tomorrow, March 21st. All docs PRs must be reviewed and ready to merge by April 4th. To mark a pull request as ready for review, navigate to the merge box and click Ready for review. Regarding the content of your documentation, do your best to describe your feature and how to use it. If you need help structuring your documentation, ask in the #sig-docs Slack channel. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release. |
d764298
to
4d8c9fe
Compare
c738b75
to
547e2be
Compare
Thanks for replying! @mickeyboxell Now that the title has been changed, I've added a new section to the Service concepts page to describe the feature and add an additional blog post to describe the details of the feature. But there are two things I'm not so sure about.
|
@xuzhenglun typically docs PRs are separate from blog PRs and involve a separate set of reviewers (with some overlap). SIG Docs and reviewers from your SIG can help determine whether or not the docs are detailed enough. |
thanks for your explanation, I have separated the blog into another PR #40204. Now, this PR should contain docs only. |
/remove-area blog |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: 801c7bafb0cdc691f18d4223cc8d5dd821b0a9f6
|
add doc for KEP 3668 kubernetes/enhancements#3668
add doc in service concepts page to describes the behavior of the new Feature ServiceNodePortStaticSubrange, and the problems it solves