Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate JobMutableNodeSchedulingDirectives to GA #40063

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Graduate JobMutableNodeSchedulingDirectives to GA #40063

merged 1 commit into from
Mar 31, 2023

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Mar 16, 2023

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 16, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2023
@ahg-g ahg-g mentioned this pull request Mar 16, 2023
Closed
8 tasks
sftim
sftim reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Mar 24, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 7e6eb03
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6424d5d87b1c4e0008692a50

@mengjiao-liu
Copy link
Member

mengjiao-liu commented Mar 27, 2023 •
edited
Loading

/lgtm

Preview page: https://deploy-preview-40063--kubernetes-io-vnext-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cecb62bb1f305a23252a0cc6740dc071a92b5cb9

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2023
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/ja Issues or PRs related to Japanese language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 30, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 30, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2023
@tengqm
Copy link
Contributor

tengqm commented Mar 30, 2023

Something is wrong, @ahg-g. This PR is not supposed to change 310 pages.

@ahg-g
Copy link
Member Author

ahg-g commented Mar 30, 2023

Something is wrong, @ahg-g. This PR is not supposed to change 310 pages.

I fixed the rebase, thanks.

@tengqm
Copy link
Contributor

tengqm commented Mar 30, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ecdea91c4dad881ff68193e1018e620ebe30033c

@tengqm
Copy link
Contributor

tengqm commented Mar 31, 2023

/remove-language de
/remove-language es
/remove-language fr
/remove-language hi
/remove-language pt
/remove-language ja
/remove-language pt
/remove-language ru
/remove-language zh

@k8s-ci-robot k8s-ci-robot removed language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/pt Issues or PRs related to Portuguese language language/ja Issues or PRs related to Japanese language labels Mar 31, 2023
@tengqm
Copy link
Contributor

tengqm commented Mar 31, 2023

/approve

@k8s-ci-robot k8s-ci-robot removed language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language labels Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 89806e9 into kubernetes:dev-1.27 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@tengqm tengqm tengqm left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

Assignees

@tengqm tengqm

@mengjiao-liu mengjiao-liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
5 participants
@ahg-g @mengjiao-liu @k8s-ci-robot @tengqm @sftim