Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to kubectl convert #40737

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Add link to kubectl convert #40737

merged 2 commits into from
Jul 16, 2023

Conversation

piradata
Copy link
Contributor

Add link to kubectl convert installation instructions and deprecation notes.

More info here:

#28724 (comment)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 17, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: piradata / name: PIRADATA (4d91822)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 17, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @piradata!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 17, 2023
@piradata piradata mentioned this pull request Apr 17, 2023
Closed
@netlify
Copy link

netlify bot commented Apr 17, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1d8150a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6465a052b8462c0008a1903a
😎 Deploy Preview https://deploy-preview-40737--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dipesh-rawat
Copy link
Member

@piradata Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

dipesh-rawat
dipesh-rawat reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 17, 2023
@piradata
Copy link
Contributor Author

/easycla

@piradata
Copy link
Contributor Author

I think the sign is ok now, but you have send the /easycla before me hahah

sftim
sftim previously requested changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've provided feedback as inline comments.

content/en/docs/reference/using-api/deprecation-guide.md Outdated Show resolved Hide resolved
content/en/docs/reference/using-api/deprecation-guide.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2023
@sftim sftim dismissed their stale review April 26, 2023 16:42

Review was stale

sftim
sftim reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but it's wrong right now and needs a fix.

Have a look at https://deploy-preview-40737--kubernetes-io-main-staging.netlify.app/docs/reference/using-api/deprecation-guide/#migrate-to-non-deprecated-apis to see how the indentation is causing the wrong formatting.

content/en/docs/reference/using-api/deprecation-guide.md Outdated Show resolved Hide resolved
content/en/docs/reference/using-api/deprecation-guide.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Apr 27, 2023

Thanks

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 27, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e0b9807b7ebd11d1da8f82ca4c043b5e19fee7e9

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim April 28, 2023 00:49
@piradata
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@piradata: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Apr 29, 2023

If you make the remaining changes, we can merge this. It you know how to rebase against main, doing that is even better.

@piradata
Copy link
Contributor Author

@sftim done :)

@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2023
@tengqm
Copy link
Contributor

tengqm commented May 17, 2023

Please limit your change to English upstream only.
The zh-cn localization team will sync the changes later.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2023
@sftim
Copy link
Contributor

sftim commented May 22, 2023

/remove-language zh

@k8s-ci-robot k8s-ci-robot removed the language/zh Issues or PRs related to Chinese language label May 22, 2023
sftim
sftim reviewed May 22, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

provided this is either labelled to merge with a squash, or has been squashed by its author

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 41e566ec40f730a0660e4507742b4a4340f055e0

@piradata
Copy link
Contributor Author

hello, there is something i need to do on my side yet?

@sftim
Copy link
Contributor

sftim commented Jul 8, 2023

Hi @piradata

We're short of capacity for people to check changes. If a Kubernetes docs contributor sets their LGTM on this PR, I can approve it.

@reylejano
Copy link
Member

Preview: https://deploy-preview-40737--kubernetes-io-main-staging.netlify.app/docs/reference/using-api/deprecation-guide/

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1eabaee into kubernetes:main Jul 16, 2023
richabanker pushed a commit to richabanker/website that referenced this pull request Jul 24, 2023
@piradata @richabanker
Add link to kubectl convert (kubernetes#40737)
7d3f978 
* added also to chinesed translations, rebased and squashed

* revert chinese update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@tengqm tengqm tengqm left review comments

@liggitt liggitt Awaiting requested review from liggitt

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@piradata @k8s-ci-robot @dipesh-rawat @sftim @tengqm @reylejano