Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove featuregate DevicePlugins #41095

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

carlory
Copy link
Member

@carlory carlory commented May 12, 2023

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone May 12, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 12, 2023
@k8s-ci-robot k8s-ci-robot requested a review from bradtopol May 12, 2023 06:11
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 12, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 12, 2023
@Shubham82
Copy link
Contributor

Thanks @carlory for the PR.
The changes look good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 497c7b0667a6b2b03422af18067d717bf4083568

@tengqm
Copy link
Contributor

tengqm commented May 12, 2023

In https://k8s.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/, it is still said that

{{< note >}}
Although the Device Manager component of Kubernetes is a generally available feature,
the _device plugin API_ is not stable. For information on the device plugin API and
version compatibility, read [Device Plugin API versions](/docs/reference/node/device-plugin-api-versions/).
{{< /note >}}

Do we need to revise this?

1 similar comment
@tengqm
Copy link
Contributor

tengqm commented May 12, 2023

In https://k8s.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/, it is still said that

{{< note >}}
Although the Device Manager component of Kubernetes is a generally available feature,
the _device plugin API_ is not stable. For information on the device plugin API and
version compatibility, read [Device Plugin API versions](/docs/reference/node/device-plugin-api-versions/).
{{< /note >}}

Do we need to revise this?

@Shubham82
Copy link
Contributor

I think we can remove this note, as it is stable now and the feature gate is removed.
WDYT? @carlory @tengqm

@carlory
Copy link
Member Author

carlory commented May 12, 2023

@Shubham82 The graduation of the API and the DeviceManager component is split, according to this discussion https://kubernetes.slack.com/archives/C0BP8PW9G/p1667481109075849.

The graduation of the API is tracking, see kubernetes/kubernetes#113587.

@tengqm @Shubham82 what do you think ?

{{< note >}}
Although the Device Manager component of Kubernetes was graduated in v1.26,
the _device plugin API_ is not stable. For information on the device plugin API and
version compatibility, read [Device Plugin API versions](/docs/reference/node/device-plugin-api-versions/).
{{< /note >}}

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2023
@k8s-ci-robot k8s-ci-robot requested a review from Shubham82 May 12, 2023 08:43
@Shubham82
Copy link
Contributor

@carlory can we mention the issue k8s/k8s #113587 here, for better understanding of readers i.e. we Device Plugin API didn't graduate alongside the DeviceManager.

@carlory
Copy link
Member Author

carlory commented May 12, 2023

@Shubham82 done.

@sftim
Copy link
Contributor

sftim commented May 15, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 15, 2023
@carlory
Copy link
Member Author

carlory commented May 16, 2023

/cc @tengqm @Shubham82

@k8s-ci-robot k8s-ci-robot requested a review from tengqm May 16, 2023 00:45
@tengqm
Copy link
Contributor

tengqm commented May 16, 2023

Thanks.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 16, 2023
@Shubham82
Copy link
Contributor

@carlory, Rebase your changes.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2023
@carlory
Copy link
Member Author

carlory commented May 17, 2023

@Shubham82 done

@Shubham82
Copy link
Contributor

Shubham82 commented May 17, 2023

JFI: This PR also removed the graduated feature gate DelegateFSGroupToCSIDriver

@Shubham82
Copy link
Contributor

Thanks, @carlory
it looks good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 19b8fa7392949c7a7a860e0433442e26557733d3

@k8s-ci-robot k8s-ci-robot merged commit 78ccaa5 into kubernetes:dev-1.28 May 17, 2023
@carlory carlory deleted the fix-003 branch May 17, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

5 participants