Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] fix markdown lint error in website/content/zh-cn/docs/concepts/o… #41450

Merged

Conversation

KKtheGhost
Copy link
Contributor

PR Summary

Fixed and Markdown typo error in page (zh-cn) Namespaces.

The current zh-cn Namespaces page looks like this:

The current en Namespaces page looks like this:

In short, at the beginning of this document page, the term "Namespace" should be presented in italic font, without bold formatting.

Furthermore, there is currently a missing half-width space character after the asterisk symbol in the current page, which is actually causing the display issue.




Best Regards,
Kivinsae Fang

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 4, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: KKtheGhost / name: Kivinsae Fang (06cc9f1)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @KKtheGhost!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from kinzhi June 4, 2023 09:36
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Jun 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from windsonsea June 4, 2023 09:36
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 4, 2023
@netlify
Copy link

netlify bot commented Jun 4, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 06cc9f1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/647c71011e3be40008cfd1d0
😎 Deploy Preview https://deploy-preview-41450--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KKtheGhost, a bold font is preferred rather than an italic in Chinese. In this case, you only need to add a space after ** to make the bold build successful. See localiztion-zh style guide.

@KKtheGhost
Copy link
Contributor Author

@windsonsea
Sorry for the bothering.
It seems that the Netlify pipeline was failed due to some timeout issue during the buiding process.
Could I request a second build check?

Thanks for any reply! Best regards,

@windsonsea
Copy link
Member

windsonsea commented Jun 4, 2023

@windsonsea Sorry for the bothering. It seems that the Netlify pipeline was failed due to some timeout issue during the buiding process. Could I request a second build check?

Thanks for any reply! Best regards,

Sure, you can run the following command to trigger ci again after you modify it locally:

git add .
git commit --amend --no-edit
git push -f

oh, you need squash your commits now.

@KKtheGhost
Copy link
Contributor Author

@windsonsea Sorry for the bothering. It seems that the Netlify pipeline was failed due to some timeout issue during the buiding process. Could I request a second build check?
Thanks for any reply! Best regards,

Sure, you can run the following command to trigger ci again after you modify it locally:

git add .
git commit --amend --no-edit
git push -f

oh, you need squash your commits now.

Copy that. I will do the squash then. Thank you!

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2023
@KKtheGhost KKtheGhost force-pushed the fix/zh-cn_namespace_md_lint branch from 71d300f to 699e07b Compare June 4, 2023 11:03
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2023
…verview/working-with-objects/namespaces.md
@KKtheGhost KKtheGhost force-pushed the fix/zh-cn_namespace_md_lint branch from 699e07b to 06cc9f1 Compare June 4, 2023 11:09
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2023
@KKtheGhost
Copy link
Contributor Author

KKtheGhost commented Jun 4, 2023

@windsonsea
Hi Michael.
I have squashed multiple commits into one commit.

Thanks for the review in advance.

Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f831712332232e2a358daddf310ce82cdeb03c25

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windsonsea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6e5c6d2 into kubernetes:main Jun 4, 2023
@KKtheGhost KKtheGhost deleted the fix/zh-cn_namespace_md_lint branch June 7, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants