Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the keyword new from dynamic-resource-allocation.md #41483

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Removed the keyword new from dynamic-resource-allocation.md #41483

merged 2 commits into from
Jun 13, 2023

Conversation

vaibhav2107
Copy link
Member

Ref: #41482

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jun 5, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from klueska and pohly June 5, 2023 18:39
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 5, 2023
@vaibhav2107
Copy link
Member Author

/cc @sftim

@k8s-ci-robot k8s-ci-robot requested a review from sftim June 5, 2023 18:39
@tengqm
Copy link
Contributor

tengqm commented Jun 5, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 273fd35b1b36097a0cf1b092df1ae3dea8fcd5c4

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from tengqm June 8, 2023 08:57
@vaibhav2107
Copy link
Member Author

@tengqm @sftim @pohly I have updated the change.
Could you please have a look

pohly
pohly approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c0b550717a7315699f211091b72d40d41780da0

@vaibhav2107
Copy link
Member Author

Thanks @pohly

@tengqm
Copy link
Contributor

tengqm commented Jun 13, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 290b12c into kubernetes:dev-1.28 Jun 13, 2023
@vaibhav2107 vaibhav2107 mentioned this pull request Jun 13, 2023
Closed
matthyx pushed a commit to matthyx/website that referenced this pull request Jul 4, 2023
@vaibhav2107 @matthyx
Removed the keyword new from dynamic-resource-allocation.md (kubernet…
6b5498c 
…es#41483)

* Removed the new keyword from dynamic-resource-allocation.md

* Updated the grammar in dynamic-resource-allocation.md
richabanker pushed a commit to richabanker/website that referenced this pull request Jul 23, 2023
@vaibhav2107 @richabanker
Removed the keyword new from dynamic-resource-allocation.md (kubernet…
d50dadd 
…es#41483)

* Removed the new keyword from dynamic-resource-allocation.md

* Updated the grammar in dynamic-resource-allocation.md
helayoty pushed a commit to helayoty/website that referenced this pull request Aug 7, 2023
@vaibhav2107 @helayoty
Removed the keyword new from dynamic-resource-allocation.md (kubernet…
b057cd1 
…es#41483)

* Removed the new keyword from dynamic-resource-allocation.md

* Updated the grammar in dynamic-resource-allocation.md
helayoty pushed a commit to helayoty/website that referenced this pull request Aug 7, 2023
@vaibhav2107 @helayoty
Removed the keyword new from dynamic-resource-allocation.md (kubernet…
2d33a5b 
…es#41483)

* Removed the new keyword from dynamic-resource-allocation.md

* Updated the grammar in dynamic-resource-allocation.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@klueska klueska Awaiting requested review from klueska

@sftim sftim Awaiting requested review from sftim

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@pohly pohly

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.
5 participants
@vaibhav2107 @tengqm @k8s-ci-robot @pohly @sftim