Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the link of Obsolete online interactive tutorial in the Confi… #42495

Closed

Conversation

sandy-ai-arch
Copy link

Removed the link for Obsolete online interactive tutorial in the Configuring a Java Microservice page for kubernetes documentation

@sandy-ai-arch
Copy link
Author

/easycla

@k8s-ci-robot k8s-ci-robot requested a review from bradtopol August 10, 2023 18:03
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 10, 2023
@k8s-ci-robot k8s-ci-robot requested a review from reylejano August 10, 2023 18:03
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 10, 2023
@netlify
Copy link

netlify bot commented Aug 10, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a09a0a2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/655f4b4542e9ac0008dc1b54
😎 Deploy Preview https://deploy-preview-42495--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@divya-mohan0209
Copy link
Contributor

@sandy-krishna-ai Thanks for this change. But this is in alignment with what we had planned for.

Reference discussion items/PRs/issues:
#40306
#40292
#33936

@divya-mohan0209
Copy link
Contributor

divya-mohan0209 commented Aug 11, 2023

Commented on the issue #42401 , however leaving it here for the visibility of other reviewers and approvers

"Hello folks, thank you for bringing this up!

The link you all are trying to drop is from a tutorial page itself, which in turn, redirects to another tutorial page that is interactive in nature.

Removal of the interactive tutorial section will not benefit this page UNLESS somebody is willing to rewrite the whole page to remove all mentions of the interactive tutorial in it & make the overall text seem sensible.

If that seems like something you want to attempt, I'd be happy to see those changes suggested over a PR.

But the changes to just remove the section as a quick fix will not fit the flow of the document, IMO."

@sftim
Copy link
Contributor

sftim commented Aug 20, 2023

We shouldn't make this change. @sandy-krishna-ai what are your plans for this PR?

We can close this for you if you are not sure how to adjust this to something we could merge.

@sandy-ai-arch
Copy link
Author

@sftim
Could you please assist me here,
Kind of stuck, Not sure how to proceed further!
Note: I am a first time contributor on Kubernetes

@sftim
Copy link
Contributor

sftim commented Aug 21, 2023

Try this:

  • delete Configuring a Java Microservice page
  • edit other pages not to link to that page

@sandy-ai-arch sandy-ai-arch deleted the remove-java-config branch August 21, 2023 10:37
@sandy-ai-arch sandy-ai-arch restored the remove-java-config branch August 21, 2023 10:39
@sandy-ai-arch sandy-ai-arch reopened this Aug 21, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 21, 2023
@sandy-ai-arch
Copy link
Author

@sftim, Thanks for helping me out!
I have removed the page configuring a java microservice & I can't see any other pages linked to this page
Please have a look at latest commit

@tengqm
Copy link
Contributor

tengqm commented Oct 10, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@AmarNathChary
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 22, 2023
@AmarNathChary
Copy link
Contributor

Please squash your PR into a single commit

@nate-double-u
Copy link
Contributor

I suggest we remove the entire "Objectives" section in content/en/docs/tutorials/configuration/external-configuration-using-microprofile.md rather than just removing the link to the old tutorial.

@sftim
Copy link
Contributor

sftim commented Nov 30, 2023

I think we ought to remove https://kubernetes.io/docs/tutorials/configuration/configure-java-microservice/ entirely.

Does that seem reasonable?

@kbhawkey
Copy link
Contributor

Hello @sandy-ai-arch .
Do you have more changes to add?

@kbhawkey
Copy link
Contributor

Let's hold this pull request. After the changes, I'm not clear on the focus of the tutorial page.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2023
@divya-mohan0209
Copy link
Contributor

divya-mohan0209 commented Jan 22, 2024

Hello @sandy-ai-arch , I'll be closing off this PR since there isn't any response from your end since August. Please note that if you have the bandwidth to advise on the suggestions above, we'd be happy to pick this up where we left off and you just need to issue the /reopen command to do so.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@divya-mohan0209
Copy link
Contributor

Mistaken approve command issued there, my bad.
/close

@k8s-ci-robot
Copy link
Contributor

@divya-mohan0209: Closed this PR.

In response to this:

Mistaken approve command issued there, my bad.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants