Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3668: promote ServiceNodePortStaticSubrange to stable #42774

Merged
merged 1 commit into from
Sep 16, 2023
Merged

KEP-3668: promote ServiceNodePortStaticSubrange to stable #42774

merged 1 commit into from
Sep 16, 2023

Conversation

xuzhenglun
Copy link
Contributor

This PR promotes KEP-3668: ServiceNodePortStaticSubrange to stable

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Aug 29, 2023
@netlify
Copy link

netlify bot commented Aug 29, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2ff476c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64ef1a63905adc00082d0c84

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 29, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kbhawkey August 29, 2023 12:21
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 29, 2023
@xuzhenglun xuzhenglun mentioned this pull request Aug 29, 2023
Closed
16 tasks
@xuzhenglun xuzhenglun changed the title promote ServiceNodePortStaticSubrange to stable KEP-3668: promote ServiceNodePortStaticSubrange to stable Aug 29, 2023
@sftim
Copy link
Contributor

sftim commented Aug 29, 2023

Hi @xuzhenglun

The PR description isn't right; this PR is only changing docs. The actual promotion to stable would be a pull request against k/kubernetes.

@sftim
Copy link
Contributor

sftim commented Aug 29, 2023

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Aug 29, 2023
@sftim
Copy link
Contributor

sftim commented Aug 29, 2023

@xuzhenglun usually we'd expect this PR to also update any of the docs around the Service API that are relevant to this feature.

tengqm
tengqm reviewed Aug 30, 2023
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -187,7 +187,7 @@ For a reference to old feature gates that are removed, please refer to
| `SELinuxMountReadWriteOncePod` | `true` | Beta | 1.27 | |
| `SecurityContextDeny` | `false` | Alpha | 1.27 | |
| `ServiceNodePortStaticSubrange` | `false` | Alpha | 1.27 | 1.27 |
| `ServiceNodePortStaticSubrange` | `true` | Beta | 1.28 | |
| `ServiceNodePortStaticSubrange` | `true` | Beta | 1.28 | 1.28 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a gate is GA'ed, the gate should be mentioned only in the second table.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are supposed to remove line 189 and 190, that is what we call "moving" rather than "copying", right?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2023
@xuzhenglun
Copy link
Contributor Author

@sftim

The PR description isn't right; this PR is only changing docs. The actual promotion to stable would be a pull request against k/kubernetes.

PR to k/k has been submit in kubernetes/kubernetes#120233

usually we'd expect this PR to also update any of the docs around the Service API that are relevant to this feature.

docs about this feature has been added since v1.27. I'm not sure about the next steps, perhaps I should remove the description of the feature gate GA in this release?

@tengqm
Thanks, it's fixed.

tengqm
tengqm reviewed Aug 30, 2023
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -187,7 +187,7 @@ For a reference to old feature gates that are removed, please refer to
| `SELinuxMountReadWriteOncePod` | `true` | Beta | 1.27 | |
| `SecurityContextDeny` | `false` | Alpha | 1.27 | |
| `ServiceNodePortStaticSubrange` | `false` | Alpha | 1.27 | 1.27 |
| `ServiceNodePortStaticSubrange` | `true` | Beta | 1.28 | |
| `ServiceNodePortStaticSubrange` | `true` | Beta | 1.28 | 1.28 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are supposed to remove line 189 and 190, that is what we call "moving" rather than "copying", right?

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -341,6 +341,9 @@ For a reference to old feature gates that are removed, please refer to
| `ServiceInternalTrafficPolicy` | `false` | Alpha | 1.21 | 1.21 |
| `ServiceInternalTrafficPolicy` | `true` | Beta | 1.22 | 1.25 |
| `ServiceInternalTrafficPolicy` | `true` | GA | 1.26 | - |
| `ServiceNodePortStaticSubrange` | `false` | Alpha | 1.27 | 1.27 |
| `ServiceNodePortStaticSubrange` | `true` | Beta | 1.28 | 1.28 |
| `ServiceNodePortStaticSubrange` | `true` | GA | 1.28 | - |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `ServiceNodePortStaticSubrange` | `true` | GA | 1.28 | - |
| `ServiceNodePortStaticSubrange` | `true` | GA | 1.29 | |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my mistake. It's should be fine now. :)

@tengqm
Copy link
Contributor

tengqm commented Aug 30, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9b0a2b1f33d8aba04a5918022a1bce4c37128b9f

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit c203889 into kubernetes:dev-1.29 Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@xuzhenglun @sftim @tengqm @k8s-ci-robot @kbhawkey