Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs to promote PodReadyToStartContainersCondition into beta #43533

Merged
merged 4 commits into from
Nov 27, 2023
Merged

update docs to promote PodReadyToStartContainersCondition into beta #43533

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c71a216
update docs to promote PodReadyToStartContainersCondition into beta
charles-chenzz Oct 17, 2023
50ea975
update pod-lifecycle.md to reflect the state of podreadytostartcontainer
charles-chenzz Nov 16, 2023
e109ce7
first round of comment address
charles-chenzz Nov 16, 2023
a8d08be
third round of comment address
charles-chenzz Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions content/en/docs/concepts/workloads/pods/pod-lifecycle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ through which the Pod has or has not passed. Kubelet manages the following
PodConditions:

* `PodScheduled`: the Pod has been scheduled to a node.
* `PodReadyToStartContainers`: (alpha feature; must be [enabled explicitly](#pod-has-network)) the
* `PodReadyToStartContainers`: (beta feature; enable by [default now](#pod-has-network)) the
charles-chenzz marked this conversation as resolved.
Show resolved Hide resolved
Pod sandbox has been successfully created and networking configured.
* `ContainersReady`: all containers in the Pod are ready.
* `Initialized`: all [init containers](/docs/concepts/workloads/pods/init-containers/)
Expand Down Expand Up @@ -242,17 +242,16 @@ When a Pod's containers are Ready but at least one custom condition is missing o

### Pod network readiness {#pod-has-network}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim wdyt about changing the name of this section? This was the name of the old condition and we renamed it to PodReadyToStartContainers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about “Pod sandbox readiness”, then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make that change after this PR lands.


{{< feature-state for_k8s_version="v1.25" state="alpha" >}}
{{< feature-state for_k8s_version="v1.29" state="beta" >}}

{{< note >}}
This condition was renamed from PodHasNetwork to PodReadyToStartContainers.
This condition was renamed from PodHasNetwork to PodReadyToStartContainers. And now is enable by default
charles-chenzz marked this conversation as resolved.
Show resolved Hide resolved
{{< /note >}}

After a Pod gets scheduled on a node, it needs to be admitted by the Kubelet and
have any volumes mounted. Once these phases are complete, the Kubelet works with
charles-chenzz marked this conversation as resolved.
Show resolved Hide resolved
a container runtime (using {{< glossary_tooltip term_id="cri" >}}) to set up a
runtime sandbox and configure networking for the Pod. If the
`PodReadyToStartContainersCondition` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) is enabled,
runtime sandbox and configure networking for the Pod,
charles-chenzz marked this conversation as resolved.
Show resolved Hide resolved
Kubelet reports whether a pod has reached this initialization milestone through
charles-chenzz marked this conversation as resolved.
Show resolved Hide resolved
the `PodReadyToStartContainers` condition in the `status.conditions` field of a Pod.

Expand Down
3 changes: 2 additions & 1 deletion content/en/docs/reference/command-line-tools-reference/feature-gates.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ For a reference to old feature gates that are removed, please refer to
| `PodHostIPs` | `false` | Alpha | 1.28 | |
| `PodIndexLabel` | `true` | Beta | 1.28 | |
| `PodLifecycleSleepAction` | `false` | Alpha | 1.29 | |
| `PodReadyToStartContainersCondition` | `false` | Alpha | 1.28 | |
| `PodReadyToStartContainersCondition` | `false` | Alpha | 1.28 | 1.28 |
| `PodReadyToStartContainersCondition` | `true` | Beta | 1.29 | |
charles-chenzz marked this conversation as resolved.
Show resolved Hide resolved
| `PodSchedulingReadiness` | `false` | Alpha | 1.26 | 1.26 |
| `PodSchedulingReadiness` | `true` | Beta | 1.27 | |
| `ProcMountType` | `false` | Alpha | 1.12 | |
Expand Down