Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LegacyServiceAccountTokenCleanUp feature in beta #43563

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Add LegacyServiceAccountTokenCleanUp feature in beta #43563

merged 1 commit into from
Nov 22, 2023

Conversation

yt2985
Copy link
Contributor

@yt2985 yt2985 commented Oct 18, 2023 •
edited
Loading

@netlify
Copy link

netlify bot commented Oct 18, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit bcb527b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65564fa2720d65000850b10c

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d55c3b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/653c42f11695530008896b9b
😎 Deploy Preview https://deploy-preview-43563--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Oct 18, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 19, 2023

LGTM

@Shubham82
Copy link
Contributor

@yt2985, The LegacyServiceAccountTokenCleanUp feature gate will be in beta in the k8s v1.29 release, so this PR will be for the dev-1.29 branch not for the main branch.

@Shubham82
Copy link
Contributor

Adding hold label, as upstream PR not merged.
Please remove the hold label once the upstream PR merges.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2023
@liggitt liggitt mentioned this pull request Oct 19, 2023
Closed
39 tasks
@liggitt liggitt mentioned this pull request Oct 27, 2023
Merged
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2023
@yt2985 yt2985 changed the base branch from main to dev-1.29 October 27, 2023 23:35
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2023
@yt2985 yt2985 closed this Oct 27, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 27, 2023
@yt2985 yt2985 reopened this Oct 28, 2023
@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2023
@liggitt
Copy link
Member

liggitt commented Nov 14, 2023

/assign

@yt2985 yt2985 force-pushed the dev-1.29 branch 4 times, most recently from a49200d to bcb01e1 Compare November 14, 2023 19:24
@zshihang
Copy link
Contributor

the general structure of the doc looks good.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 178a326992a33a917e09fbad29fa26255c2ede40

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2023
@katcosgrove
Copy link
Contributor

Hi, @yt2985! Kubernetes v1.29 Docs Lead here. Just a reminder that the deadline to have this PR reviewed and merged is Tuesday, 28 November. Let me know if you need any help!

CCing KEP owners: @liggitt @zshihang

@zshihang
Copy link
Contributor

/lgtm

@sftim could you review again so that we can get it merged in time?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00c8cac22b3738eb348dcfa3ee66167b1f7d8756

@liggitt
Copy link
Member

liggitt commented Nov 21, 2023

/lgtm

@tengqm
Copy link
Contributor

tengqm commented Nov 22, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@zshihang
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 421821d into kubernetes:dev-1.29 Nov 22, 2023
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@tengqm tengqm tengqm left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@liggitt liggitt Awaiting requested review from liggitt

@zshihang zshihang Awaiting requested review from zshihang

Assignees

@liggitt liggitt

@zshihang zshihang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
10 participants
@yt2985 @dipesh-rawat @tengqm @Shubham82 @zshihang @sftim @jihoon-seo @k8s-ci-robot @liggitt @katcosgrove