-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KEP-127] Add documentation about user namespaces and PSS #43803
Merged
k8s-ci-robot
merged 1 commit into
kubernetes:dev-1.29
from
kinvolk:dev-1.29-user-namespaces-pss
Nov 28, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -212,6 +212,7 @@ For a reference to old feature gates that are removed, please refer to | |
| `TopologyManagerPolicyOptions` | `true` | Beta | 1.28 | | | ||
| `TranslateStreamCloseWebsocketRequests` | `false` | Alpha | 1.29 | | | ||
| `UnknownVersionInteroperabilityProxy` | `false` | Alpha | 1.28 | | | ||
| `UserNamespacesPodSecurityStandards` | `false` | Alpha | 1.29 | | | ||
| `UserNamespacesSupport` | `false` | Alpha | 1.28 | | | ||
| `ValidatingAdmissionPolicy` | `false` | Alpha | 1.26 | 1.27 | | ||
| `ValidatingAdmissionPolicy` | `false` | Beta | 1.28 | | | ||
|
@@ -803,6 +804,10 @@ Each feature gate is designed for enabling/disabling a specific feature: | |
- `UnknownVersionInteroperabilityProxy`: Proxy resource requests to the correct peer kube-apiserver when | ||
multiple kube-apiservers exist at varied versions. | ||
See [Mixed version proxy](/docs/concepts/architecture/mixed-version-proxy/) for more information. | ||
- `UserNamespacesPodSecurityStandards`: Enable Pod Security Standards policies relaxation for pods | ||
that run with namespaces. You must set the value of this feature gate consistently across all nodes in | ||
your cluster, and you must also enable `UserNamespacesSupport` to use this feature. | ||
See [User Namespaces](/docs/concepts/workloads/pods/user-namespaces/#integration-with-pod-security-standards) for more details. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oops. Should be: - See [User Namespaces](/docs/concepts/workloads/pods/user-namespaces/#integration-with-pod-security-standards) for more details.
+ See [User Namespaces](/docs/concepts/workloads/pods/user-namespaces/#integration-with-pod-security-admission-checks) for more details. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixing in the follow-up PR. |
||
- `UserNamespacesSupport`: Enable user namespace support for Pods. | ||
Before Kubernetes v1.28, this feature gate was named `UserNamespacesStatelessPodsSupport`. | ||
- `ValidatingAdmissionPolicy`: Enable [ValidatingAdmissionPolicy](/docs/reference/access-authn-authz/validating-admission-policy/) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the change should really be made to https://kubernetes.io/docs/concepts/security/pod-security-admission/, and then have a small section in the user namespaces concept that links to the relevant part of the PSA docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean pod security admission or pod security standards? That page you link doesn't seem related, but this one (about pod security standards) does: https://kubernetes.io/docs/concepts/security/pod-security-standards/
Can you explain why pod security admisions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, because that's where the feature gate has an effect.
Think about it like this: imagine we were adding support for TLS 1.3; we'd document that in our pages about configuring transport layer security and maybe around setting which TLS versions were supported. But we wouldn't propose an update to https://datatracker.ietf.org/doc/html/rfc8446
On the other hand, if someone does want to revise the TLS standard, they don't put the update to the standard behind a feature gate. But they might have a feature gate to - eg - enable the
RSASSA-PSS
signature scheme.I don't really understand how you feature gate a standard.