Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Move "what-is-kubernetes" to "Overview" page #43942

Closed

Conversation

abhay-raj19
Copy link
Contributor

Ref : #42844

As suggested by @aj11anuj I had updated up those changes .

Copy link

linux-foundation-easycla bot commented Nov 14, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @abhay-raj19!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 14, 2023
@dipesh-rawat
Copy link
Member

/retitle [hi] Move "what-is-kubernetes" to "Overview" page

@k8s-ci-robot k8s-ci-robot changed the title fixed:42844/what_is_k8s into _index.md [hi] Move "what-is-kubernetes" to "Overview" page Nov 15, 2023
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! It appears that there are some incomplete or inaccurate changes in the PR, as the Netlify build preview is encountering following error :

10:58:25 PM: Start building sites …
10:58:25 PM: hugo v0.111.3-5d4eb5154e1fed125ca8e9b5a0315c4180dab192+extended linux/amd64 BuildDate=2023-03-12T11:40:50Z VendorInfo=gohugoio
10:59:32 PM: ERROR 2023/11/14 22:59:32 [hi] REF_NOT_FOUND: Ref "/docs/concepts/overview/what-is-kubernetes": "/opt/build/repo/content/hi/_index.html:1:1": page not found
10:59:35 PM: Error: Error building site: logged 1 error(s)
10:59:35 PM: Total in 70181 ms
10:59:35 PM: make: *** [Makefile:43: deploy-preview] Error 255

Please address these build errors before the PR can be deemed ready for review and merging.

@dipesh-rawat
Copy link
Member

/hold
Explicit hold to avoid accidental merges.
(Ok to unhold once the build errors are rectified)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023
Copy link
Member

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build error can be resolved by following options:-

  1. Revert it to normal state, then 1st make a PR for changing title key-value pair only. Let that PR merged and then make another PR for renaming the file.
  2. Revert it to normal state, then make a commit for creating a new file with updated key-value pair and name as _index.md inside /hi/docs/concepts/overview/ directory, after that make another commit for deleting whole what-is-kubernetes.md file.

Both of the above options are high likely to resolve this issue, choose whichever you find convenient.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I interpret the build error correctly, it seems that the renaming of the file may require a corresponding change in /content/hi/_index.html

10:59:32 PM: ERROR 2023/11/14 22:59:32 [hi] REF_NOT_FOUND: Ref "/docs/concepts/overview/what-is-kubernetes": "/opt/build/repo/content/hi/_index.html:1:1": page not found
10:59:35 PM: Error: Error building site: logged 1 error(s)

@abhay-raj19 Please navigate to Line 11 in /content/hi/_index.html and consider changing following text (deleting 'what-is-kubernetes' text from file) :

- {{< relref "/docs/concepts/overview/what-is-kubernetes" >}}
+ {{< relref "/docs/concepts/overview/" >}}

Check if the above change resolves the error and allows for further progress. I hope this suggestion proves helpful.

@abhay-raj19
Copy link
Contributor Author

If I interpret the build error correctly, it seems that the renaming of the file may require a corresponding change in /content/hi/_index.html

10:59:32 PM: ERROR 2023/11/14 22:59:32 [hi] REF_NOT_FOUND: Ref "/docs/concepts/overview/what-is-kubernetes": "/opt/build/repo/content/hi/_index.html:1:1": page not found
10:59:35 PM: Error: Error building site: logged 1 error(s)

@abhay-raj19 Please navigate to Line 11 in /content/hi/_index.html and consider changing following text (deleting 'what-is-kubernetes' text from file) :

- {{< relref "/docs/concepts/overview/what-is-kubernetes" >}}
+ {{< relref "/docs/concepts/overview/" >}}

Check if the above change resolves the error and allows for further progress. I hope this suggestion proves helpful.

sure sure will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants