-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hi] Move "what-is-kubernetes" to "Overview" page #43942
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @abhay-raj19! |
/retitle [hi] Move "what-is-kubernetes" to "Overview" page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! It appears that there are some incomplete or inaccurate changes in the PR, as the Netlify build preview is encountering following error :
10:58:25 PM: Start building sites …
10:58:25 PM: hugo v0.111.3-5d4eb5154e1fed125ca8e9b5a0315c4180dab192+extended linux/amd64 BuildDate=2023-03-12T11:40:50Z VendorInfo=gohugoio
10:59:32 PM: ERROR 2023/11/14 22:59:32 [hi] REF_NOT_FOUND: Ref "/docs/concepts/overview/what-is-kubernetes": "/opt/build/repo/content/hi/_index.html:1:1": page not found
10:59:35 PM: Error: Error building site: logged 1 error(s)
10:59:35 PM: Total in 70181 ms
10:59:35 PM: make: *** [Makefile:43: deploy-preview] Error 255
Please address these build errors before the PR can be deemed ready for review and merging.
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This build error can be resolved by following options:-
- Revert it to normal state, then 1st make a PR for changing title key-value pair only. Let that PR merged and then make another PR for renaming the file.
- Revert it to normal state, then make a commit for creating a new file with updated key-value pair and name as
_index.md
inside/hi/docs/concepts/overview/
directory, after that make another commit for deleting wholewhat-is-kubernetes.md
file.
Both of the above options are high likely to resolve this issue, choose whichever you find convenient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I interpret the build error correctly, it seems that the renaming of the file may require a corresponding change in /content/hi/_index.html
10:59:32 PM: ERROR 2023/11/14 22:59:32 [hi] REF_NOT_FOUND: Ref "/docs/concepts/overview/what-is-kubernetes": "/opt/build/repo/content/hi/_index.html:1:1": page not found
10:59:35 PM: Error: Error building site: logged 1 error(s)
@abhay-raj19 Please navigate to Line 11 in /content/hi/_index.html and consider changing following text (deleting 'what-is-kubernetes' text from file) :
- {{< relref "/docs/concepts/overview/what-is-kubernetes" >}}
+ {{< relref "/docs/concepts/overview/" >}}
Check if the above change resolves the error and allows for further progress. I hope this suggestion proves helpful.
sure sure will do that |
Ref : #42844
As suggested by @aj11anuj I had updated up those changes .