Dev 1.29 user namespaces pss update #44156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
cncf-cla: yes
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
sig/docs
saschagrunert
force-pushed
the
dev-1.29-user-namespaces-pss-update
branch
from
ef83e45 to
5034076
Compare
sftim
reviewed
Nov 30, 2023
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ef7f856c0f605332165f99da616c1306840d5cd6
|
k8s-ci-robot
removed
the
lgtm
Signed-off-by: Sascha Grunert <sgrunert@redhat.com> Co-authored-by: Tim Bannister <tim@scalefactory.com>
saschagrunert
changed the title
saschagrunert
force-pushed
the
dev-1.29-user-namespaces-pss-update
branch
from
1eb44e0 to
8dc0806
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold For docs to include |
k8s-ci-robot
added
the
do-not-merge/hold
|
The hold doesn't make sense to me @saschagrunert - when [under what conditions] would we unhold this PR? |
|
@sftim we can unhold if everyone is fine with fixups on the dev-1.29 branch. |
|
I'm fine with it! /unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b151e07593c2d8fd6befd6525f27644caed48333
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #43803
I think it would be best to rebase the PR on top of
masteroncedev-1.29got integrated into it.