Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise details for sidecar containers #44335

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Revise details for sidecar containers #44335

merged 1 commit into from
Dec 22, 2023

Conversation

T-Lakshmi
Copy link
Contributor

Fixes #44334

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Dec 13, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 13, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e11ca25
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6582a139fc52b000086dacfb
😎 Deploy Preview https://deploy-preview-44335--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@T-Lakshmi
Copy link
Contributor Author

T-Lakshmi commented Dec 13, 2023 •
edited
Loading

Preview pages:
sidecar-containers
feature-gates

reylejano
reylejano reviewed Dec 14, 2023
View reviewed changes
content/en/docs/concepts/workloads/pods/sidecar-containers.md
Comment on lines -60 to -62
By default, this feature is not available in Kubernetes. To avail this feature, you
need to enable the [feature gate](/docs/reference/command-line-tools-reference/feature-gates/)
named `SidecarContainers`.
Copy link
Member

@reylejano reylejano Dec 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs to be verified as the related issue #44334 states that beta APIs are on by default but as of kubernetes/enhancements#3136 , beta APIs are off by default

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L20-21 should also be update to reflect what @matthyx had suggested in matthyx@29dff23

It looks like this change originally in init-containers.md was lost when sidecar-containers.md was added. It is important as at first glance the current wording gives the impression that sidecars containers are still alpha and need a feature flag set.

(Before)
Starting with Kubernetes 1.28 in alpha, a feature gate named `SidecarContainers`...

(After)
Enabled by default with Kubernetes 1.29, a feature gate named `SidecarContainers`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skaegi it is a good catch, we're indeed in beta
@reylejano the feature is ON by default:
https://github.com/kubernetes/kubernetes/blob/v1.29.0/pkg/features/kube_features.go#L1195

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skaegi, @matthyx,
Thanks for the inputs.
I have updated the PR with suggestions matthyx@29dff23.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2023
@T-Lakshmi T-Lakshmi force-pushed the sidecar-feature-change branch from 76d4f7b to f533c69 Compare December 18, 2023 10:21
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 18, 2023
@T-Lakshmi T-Lakshmi force-pushed the sidecar-feature-change branch 2 times, most recently from 8ffbe1c to cd263f6 Compare December 18, 2023 11:12
@T-Lakshmi
Copy link
Contributor Author

/remove language zh

Removing the label which was added due to merge conflict.

@T-Lakshmi
Copy link
Contributor Author

/remove-language zh

@k8s-ci-robot k8s-ci-robot removed the language/zh Issues or PRs related to Chinese language label Dec 18, 2023
@T-Lakshmi T-Lakshmi force-pushed the sidecar-feature-change branch from cd263f6 to e11ca25 Compare December 20, 2023 08:09
@reylejano
Copy link
Member

Thank you for addressing comments
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4b35e78ae26bd104d65f32f8669cbee9d909cd47

@T-Lakshmi
Copy link
Contributor Author

@reylejano Thanks for reviewing the PR.

/assign @tengqm
@tengqm, Requesting for PR approval, PTAL!
Thanks.

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit b7bd4c9 into kubernetes:main Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaegi skaegi skaegi left review comments

@kbhawkey kbhawkey kbhawkey left review comments

@matthyx matthyx matthyx left review comments

@reylejano reylejano reylejano left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@tengqm tengqm

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant information present in sidecar containers page
7 participants
@T-Lakshmi @reylejano @k8s-ci-robot @kbhawkey @skaegi @matthyx @tengqm