Skip to content

Added Imagefs inodes default settings in Eviction Hard #44696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2024
Merged

Added Imagefs inodes default settings in Eviction Hard #44696

merged 2 commits into from
Mar 25, 2024

Conversation

@vaibhav2107
Copy link
Member

@vaibhav2107 vaibhav2107 commented Jan 10, 2024

Fixes : #44695

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jan 10, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 10, 2024
@vaibhav2107
Copy link
Member Author

vaibhav2107 commented Jan 10, 2024

Hi @tengqm @kbhawkey
Could you please have a look

@netlify
Copy link

netlify bot commented Jan 10, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 36a3e21
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/659eaf673056ae00087e47a2
😎 Deploy Preview https://deploy-preview-44696--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vaibhav2107
Copy link
Member Author

vaibhav2107 commented Jan 10, 2024

@kannon92 I have updated the PR, please have a look

@kannon92
Copy link
Contributor

kannon92 commented Jan 11, 2024

LGTM to me from technical side.

@sftim is this PR targeted to the right branch? I think maybe it should go to release-1.30 but not entirely sure on this one.

We did not end up cherry-picking this so its only valid for >= 1.30.

@sftim
Copy link
Contributor

sftim commented Jan 11, 2024

Thanks

/hold
Please change the base (ie, target) branch to dev-1.30 @vaibhav2107

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2024
@sftim
Copy link
Contributor

sftim commented Jan 11, 2024

OK to unhold once the target branch is correct.

@sftim
Copy link
Contributor

sftim commented Feb 13, 2024

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 13, 2024
@kannon92
Copy link
Contributor

kannon92 commented Feb 13, 2024

@vaibhav2107 could you address this point? #44696 (comment)

@vaibhav2107
Copy link
Member Author

vaibhav2107 commented Feb 13, 2024

@kannon92 sure, I will update this

@drewhagen
Copy link
Member

drewhagen commented Mar 18, 2024 •
edited
Loading

Hello @vaibhav2107 👋, A friendly reminder of timeline, this PR needs doc review complete by Doc Freeze on March 26th 18:00 PT. Please follow up by this date with setting the base branch to dev-1.30 and have your review complete with approved and lgtm labels in order for it to be ready for this release.

Thanks!

@chanieljdan
Copy link
Contributor

chanieljdan commented Mar 24, 2024

Hello @vaibhav2107 👋, A friendly reminder of timeline, this PR needs doc review complete by Doc Freeze on March 26th 18:00 PT. Looks like technical review is complete, but to meet the Docs Freeze this PR must have lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs.

Could we change the base (ie, target) branch to dev-1.30? Once done we can finalize docs review & approval.

@vaibhav2107 vaibhav2107 changed the base branch from main to dev-1.30 March 25, 2024 16:20
@vaibhav2107
Copy link
Member Author

vaibhav2107 commented Mar 25, 2024

Hi, I have changed the target branch from base to dev-1.30, you can review the PR and let me know if something else has to be done

@vaibhav2107
Copy link
Member Author

vaibhav2107 commented Mar 25, 2024

@chanieljdan Thanks for the help

@chanieljdan
Copy link
Contributor

chanieljdan commented Mar 25, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
@drewhagen
Copy link
Member

drewhagen commented Mar 25, 2024

Given kannon92's comment

LGTM to me from technical side.

@sftim is this PR targeted to the right branch? I think maybe it should go to release-1.30 but not entirely sure on this one.

We did not end up cherry-picking this so its only valid for >= 1.30.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 25, 2024

LGTM label has been added.

Git tree hash: f64fe8865b1a62cc86feae46cfa171647e9b6962

@chanieljdan
Copy link
Contributor

chanieljdan commented Mar 25, 2024

Thanks @vaibhav2107!

@kubernetes/sig-docs-en-owners does this PR look good for approval?

@stmcginnis
Copy link
Contributor

stmcginnis commented Mar 25, 2024

/lgtm

@natalisucks
Copy link
Contributor

natalisucks commented Mar 25, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit cf6f995 into kubernetes:dev-1.30 Mar 25, 2024
@vaibhav2107
Copy link
Member Author

vaibhav2107 commented Mar 26, 2024

Thanks @natalisucks @stmcginnis

@vaibhav2107 vaibhav2107 mentioned this pull request Mar 26, 2024
Closed
@drewhagen
Copy link
Member

drewhagen commented Apr 25, 2024

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@tengqm tengqm Awaiting requested review from tengqm

1 more reviewer

@kannon92 kannon92 kannon92 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@drewhagen drewhagen

@stmcginnis stmcginnis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Archived in project
1.30 Enhancements Tracking
Status: Tracked for Doc Freeze

Milestone

1.30

Development

Successfully merging this pull request may close these issues.

Document default settings for imagefs.inodesFree in EvictionHard

8 participants

@vaibhav2107 @kannon92 @sftim @drewhagen @chanieljdan @k8s-ci-robot @stmcginnis @natalisucks