Document option to allow almost all printable ASCII characters in environment variables #45125

HirazawaUi · 2024-02-13T15:14:14Z

No description provided.

netlify · 2024-02-13T15:16:50Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`e30b057`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65cb87492933ae00089b1e10
😎 Deploy Preview	https://deploy-preview-45125--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim · 2024-02-13T16:34:04Z

/retitle [WIP]: Allow almost all printable ASCII characters in environment variables

sftim · 2024-02-13T16:34:14Z

/sig node

sftim · 2024-02-13T17:38:00Z

/retitle [WIP]: Document option to allow almost all printable ASCII characters in environment variables

fsmunoz · 2024-02-22T11:26:22Z

@HirazawaUi I think that the target branch should be 1.30 instead of main, since this is related to a feature with a 1.30 milestone - would it be possible to change it?

HirazawaUi · 2024-02-22T14:36:35Z

@HirazawaUi I think that the target branch should be 1.30 instead of main, since this is related to a feature with a 1.30 milestone - would it be possible to change it?

Ah, sorry, that was my mistake.

netlify · 2024-02-22T14:40:18Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`0c1b3e3`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/660229aac5bade00084c64c1

HirazawaUi · 2024-03-01T12:03:43Z

@sftim May you take a look at this document first? Because you have the full context and understand it well enough.

content/en/docs/tasks/inject-data-application/define-environment-variable-container.md

sftim

Thanks.

Please also amend https://kubernetes.io/docs/concepts/configuration/configmap/, https://kubernetes.io/docs/concepts/configuration/secret/ and https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/

and optionally https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/

content/en/docs/tasks/inject-data-application/define-environment-variable-container.md

sftim · 2024-03-15T16:42:07Z

@sftim May you take a look at this document first? Because you have the full context and understand it well enough.

I'm afraid we can't offer you that luxury; our SIG leads' time is popular. Please work with reviewers for English, me included, but not me exclusively. I wouldn't have the capacity to pick up all the reviews I've been invited to help out with ahead of the docs deadline.

HirazawaUi · 2024-03-15T16:48:21Z

@sftim May you take a look at this document first? Because you have the full context and understand it well enough.

I'm afraid we can't offer you that luxury; our SIG leads' time is popular. Please work with reviewers for English, me included, but not me exclusively. I wouldn't have the capacity to pick up all the reviews I've been invited to help out with ahead of the docs deadline.

Okay, I understand. Thank you for your patient comment. I will communicate directly with the English reviewer later.

drewhagen · 2024-03-18T16:50:13Z

/milestone 1.30

drewhagen · 2024-03-18T16:56:48Z

Hello @liggitt @thockin a reminder that this needs a technical review before being ready to merge by Docs Freeze on March 26. An exception request will be required if you cannot meet that deadline.

@kubernetes/sig-docs-en-reviews I see there is request for additional review (see comments above). Might someone other than Tim be available to assist review on this one?

Thanks everyone!

HirazawaUi · 2024-03-18T17:17:50Z

Before reviewing by sig-docs-en-reviews, I would like to hear @thockin opinion on comment. We are allowed to relax the restrictions on using EnvFrom to reference configmap/secret keys when feature gate is not enable.

Princesso · 2024-03-21T16:23:37Z

Hello @HirazawaUi 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday March 26th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

HirazawaUi · 2024-03-21T16:56:23Z

Hello @HirazawaUi 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday March 26th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

OK, I'm also waiting for the technical review. If @thockin doesn't have any free time, I will try to ask other approvers of sig-node for help.

natalisucks · 2024-03-23T10:28:24Z

@kubernetes/sig-node-leads Howdy leads, we're looking for a technical review for these docs to make the Docs Freeze deadline of March 26 – thanks!

thockin

Technical review LGTM

content/en/docs/concepts/configuration/secret.md

thockin · 2024-03-25T18:00:10Z

content/en/docs/concepts/configuration/secret.md

-0s         0s          1         dapi-test-pod   Pod                                         Warning   InvalidEnvironmentVariableNames   kubelet, 127.0.0.1      Keys [1badkey, 2alsobad] from the EnvFrom secret default/mysecret were skipped since they are considered invalid environment variable names.
-```
+ It's important to note that he range of characters allowed for environment variable names in pods is [restricted](/docs/tasks/inject-data-application/
+/define-environment-variable-container/#using-environment-variables-inside-of-your-config), 


Is this URL line-wrapped?

Sorry for my bad English, I misunderstood line-wrapped, it does contain line wrap, and has been fixed in #45670.

content/en/docs/concepts/configuration/configmap.md

mrunalp

/approve
Sig-node

drewhagen · 2024-03-26T01:48:46Z

Just a heads up that Doc Freeze is approaching fast tomorrow March 26th at 18:00 PDT and starting this cycle, we need to file an Exception after this time.
This one looks pretty close and we'd like to help you get it over the finish line!

@kubernetes/sig-docs-en-owners Does this one look good to you? We could use an approve @HirazawaUi I notice we have approvals from SIG Node leads and also there are a couple outstanding comments from Tim H. Do we want to tackle those before merge?

HirazawaUi · 2024-03-26T01:58:47Z

Just a heads up that Doc Freeze is approaching fast tomorrow March 26th at 18:00 PDT and starting this cycle, we need to file an Exception after this time. This one looks pretty close and we'd like to help you get it over the finish line!

@kubernetes/sig-docs-en-owners Does this one look good to you? We could use an approve @HirazawaUi I notice we have approvals from SIG Node leads and also there are a couple outstanding comments from Tim H. Do we want to tackle those before merge?

All comments have been fixed.

@kubernetes/sig-docs-en-owners for lgtm and approve

drewhagen · 2024-03-26T02:11:27Z

/lgtm

k8s-ci-robot · 2024-03-26T02:11:32Z

LGTM label has been added.

Git tree hash: b43623883fa08a832f00025fd74c5ad46f4553f3

divya-mohan0209

@drewhagen/@HirazawaUi: I'd recommend we check if the links for this one are wrapped properly. Other than that, I'll bias for action here.
/approve

k8s-ci-robot · 2024-03-26T02:42:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [divya-mohan0209]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

drewhagen · 2024-04-25T23:25:38Z

/milestone 1.30

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Feb 13, 2024

k8s-ci-robot requested review from mehabhalodiya and shannonxtreme February 13, 2024 15:14

k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2024

HirazawaUi mentioned this pull request Feb 13, 2024

Allow almost all printable ASCII characters in environment variables kubernetes/enhancements#4369

Closed

22 tasks

k8s-ci-robot changed the title ~~[placeholder]: Allow almost all printable ASCII characters in environment variables~~ [WIP]: Allow almost all printable ASCII characters in environment variables Feb 13, 2024

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2024

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 13, 2024

k8s-ci-robot changed the title ~~[WIP]: Allow almost all printable ASCII characters in environment variables~~ [WIP]: Document option to allow almost all printable ASCII characters in environment variables Feb 13, 2024

HirazawaUi changed the base branch from main to dev-1.30 February 22, 2024 14:37

HirazawaUi force-pushed the allow-special-characters branch from e30b057 to 29d6179 Compare February 22, 2024 14:40

HirazawaUi force-pushed the allow-special-characters branch from 29d6179 to 9ac88d5 Compare February 29, 2024 21:33

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 29, 2024

HirazawaUi changed the title ~~[WIP]: Document option to allow almost all printable ASCII characters in environment variables~~ Document option to allow almost all printable ASCII characters in environment variables Feb 29, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 29, 2024

HirazawaUi force-pushed the allow-special-characters branch from 9ac88d5 to 8141a19 Compare February 29, 2024 21:40

stmcginnis reviewed Mar 1, 2024

View reviewed changes

content/en/docs/tasks/inject-data-application/define-environment-variable-container.md Outdated Show resolved Hide resolved

content/en/docs/tasks/inject-data-application/define-environment-variable-container.md Outdated Show resolved Hide resolved

HirazawaUi force-pushed the allow-special-characters branch from 8141a19 to 48e44da Compare March 1, 2024 12:44

sftim suggested changes Mar 1, 2024

View reviewed changes

content/en/docs/tasks/inject-data-application/define-environment-variable-container.md Show resolved Hide resolved

content/en/docs/tasks/inject-data-application/define-environment-variable-container.md Outdated Show resolved Hide resolved

HirazawaUi force-pushed the allow-special-characters branch from 5c1a8d9 to 4ca339f Compare March 16, 2024 08:04

HirazawaUi mentioned this pull request Mar 16, 2024

Allow almost all printable ASCII characters in environment variables kubernetes/kubernetes#123385

Merged

HirazawaUi force-pushed the allow-special-characters branch from 4ca339f to 2f4d3e2 Compare March 16, 2024 09:27

k8s-ci-robot added this to the 1.30 milestone Mar 18, 2024

HirazawaUi force-pushed the allow-special-characters branch from 2f4d3e2 to 0ab6384 Compare March 21, 2024 16:55

thockin reviewed Mar 25, 2024

View reviewed changes

mrunalp approved these changes Mar 25, 2024

View reviewed changes

Allow almost all printable ASCII characters in environment variables

0c1b3e3

HirazawaUi force-pushed the allow-special-characters branch from 0ab6384 to 0c1b3e3 Compare March 26, 2024 01:49

k8s-ci-robot assigned drewhagen Mar 26, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2024

divya-mohan0209 reviewed Mar 26, 2024

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024

k8s-ci-robot merged commit 3d33323 into kubernetes:dev-1.30 Mar 26, 2024

HirazawaUi mentioned this pull request Mar 26, 2024

[dev-1.30] Remove useless line wrap #45670

Merged

k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024

Document option to allow almost all printable ASCII characters in environment variables #45125

Document option to allow almost all printable ASCII characters in environment variables #45125

Uh oh!

Conversation

HirazawaUi commented Feb 13, 2024

Uh oh!

netlify bot commented Feb 13, 2024

✅ Pull request preview available for checking

Uh oh!

sftim commented Feb 13, 2024

Uh oh!

sftim commented Feb 13, 2024

Uh oh!

sftim commented Feb 13, 2024

Uh oh!

fsmunoz commented Feb 22, 2024

Uh oh!

HirazawaUi commented Feb 22, 2024

Uh oh!

netlify bot commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Uh oh!

HirazawaUi commented Mar 1, 2024

Uh oh!

Uh oh!

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sftim commented Mar 15, 2024

Uh oh!

HirazawaUi commented Mar 15, 2024

Uh oh!

drewhagen commented Mar 18, 2024

Uh oh!

drewhagen commented Mar 18, 2024

Uh oh!

HirazawaUi commented Mar 18, 2024

Uh oh!

Princesso commented Mar 21, 2024

Uh oh!

HirazawaUi commented Mar 21, 2024

Uh oh!

natalisucks commented Mar 23, 2024

Uh oh!

thockin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thockin Mar 25, 2024

Choose a reason for hiding this comment

Uh oh!

HirazawaUi Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mrunalp left a comment

Choose a reason for hiding this comment

Uh oh!

drewhagen commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HirazawaUi commented Mar 26, 2024

Uh oh!

drewhagen commented Mar 26, 2024

Uh oh!

k8s-ci-robot commented Mar 26, 2024

Uh oh!

divya-mohan0209 left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Mar 26, 2024

Uh oh!

drewhagen commented Apr 25, 2024

Uh oh!

netlify bot commented Feb 22, 2024 •

edited

Loading

HirazawaUi Mar 26, 2024 •

edited

Loading

drewhagen commented Mar 26, 2024 •

edited

Loading