Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document OCI volume sources / KEP-4639 #46946

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Document OCI volume sources / KEP-4639 #46946

merged 1 commit into from
Jul 25, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 24, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jun 24, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2024
@saschagrunert saschagrunert mentioned this pull request Jun 24, 2024
Open
9 tasks
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 24, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 24, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit a12454f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66a23452fc9a290008dd7c91

@netlify Netlify
Copy link

netlify bot commented Jun 24, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a12454f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a2345292fe8a0008251bf4
😎 Deploy Preview https://deploy-preview-46946--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jun 24, 2024

/retitle [WIP] Document OCI volume sources / KEP-4639

@k8s-ci-robot k8s-ci-robot changed the title [KEP-4639] Add OCI Volume Source documentation [WIP] Document OCI volume sources / KEP-4639 Jun 24, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2024
@sftim
Copy link
Contributor

sftim commented Jun 24, 2024

/sig node storage

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jun 24, 2024
@hacktivist123
Copy link
Contributor

Hello @saschagrunert 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday, July 16th, 2024 18:00 PST. Thank you!

@Princesso
Copy link
Contributor

Hi @saschagrunert, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2024
@saschagrunert
Copy link
Member Author

Hi @saschagrunert, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

Thank you for the hint, I started working on the docs which will be ready for review before the deadline.

@saschagrunert saschagrunert force-pushed the oci-volumesource-docs branch 2 times, most recently from 367872e to 9c3285f Compare July 15, 2024 09:11
@saschagrunert saschagrunert changed the title [WIP] Document OCI volume sources / KEP-4639 Document OCI volume sources / KEP-4639 Jul 15, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2024
Princesso
Princesso reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@Princesso Princesso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/sig-node

@saschagrunert saschagrunert force-pushed the oci-volumesource-docs branch 4 times, most recently from 4399493 to 633f3c9 Compare July 23, 2024 09:13
@sftim
Copy link
Contributor

sftim commented Jul 25, 2024

Given concerns in #46946 (review):
/lgtm cancel

The main thing we should make clear is what fails when an image volume fails to pull: it's the whole Pod. It is technically also all of the containers, but volumes are a pod-level concept.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
sftim
sftim reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good to merge as is IMO.

content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3b361fd5e8b1a2d2349611d26bc936487925df25

@sftim
Copy link
Contributor

sftim commented Jul 25, 2024

@saschagrunert do you want to tweak this further? If not, let us know; I'll be happy to approve it as-is.

@saschagrunert
Copy link
Member Author

@saschagrunert do you want to tweak this further? If not, let us know; I'll be happy to approve it as-is.

I'll give it one more push in the next hour :) Thank you for the detailed review!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim July 25, 2024 10:56
@saschagrunert saschagrunert force-pushed the oci-volumesource-docs branch 2 times, most recently from 8d55fec to 636d77a Compare July 25, 2024 10:58
@saschagrunert saschagrunert force-pushed the oci-volumesource-docs branch 3 times, most recently from 4969c23 to ba64b87 Compare July 25, 2024 11:17
@saschagrunert
Add ImageVolume documentation
a12454f 
Add a basic task how to use image volumes in pods.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@sftim
Copy link
Contributor

sftim commented Jul 25, 2024

Existing LGTMs
#46946 (comment)
#46946 (comment)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7cd73c7e9117d315ab1900989ae2426bcdd3fcdc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hacktivist123, kwilczynski, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit a6ac726 into kubernetes:dev-1.31 Jul 25, 2024
6 checks passed
@saschagrunert saschagrunert deleted the oci-volumesource-docs branch July 25, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@Princesso Princesso Princesso left review comments

@hacktivist123 hacktivist123 Awaiting requested review from hacktivist123

@kwilczynski kwilczynski Awaiting requested review from kwilczynski

Assignees

@kwilczynski kwilczynski

@sftim sftim

@hacktivist123 hacktivist123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
6 participants
@saschagrunert @sftim @hacktivist123 @Princesso @kwilczynski @k8s-ci-robot