Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-4006] - Docs for PortForward over WebSockets Feature Gates (Beta) #46955

Merged
merged 1 commit into from
Jul 27, 2024
Merged

[KEP-4006] - Docs for PortForward over WebSockets Feature Gates (Beta) #46955

merged 1 commit into from
Jul 27, 2024

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jun 24, 2024 •
edited
Loading

  • Updates control plane feature flag: PortForwardWebsockets to Beta
  • Updates kubectl feature flag: KUBECTL_PORT_FORWARD_WEBSOCKETS to Beta

kubernetes/enhancements#4006

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jun 24, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2024
@seans3 seans3 marked this pull request as draft June 24, 2024 23:04
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 24, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 9a39692
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/667a33dd50755d0008186b64

@k8s-ci-robot k8s-ci-robot requested a review from sftim June 24, 2024 23:04
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 24, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tengqm June 24, 2024 23:04
@seans3 seans3 mentioned this pull request Jun 24, 2024
Open
8 tasks
@netlify Netlify
Copy link

netlify bot commented Jun 24, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9a39692
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/667a33dd1bbe670008b484c2
😎 Deploy Preview https://deploy-preview-46955--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 24, 2024
@seans3 seans3 force-pushed the kep-4006-portforward-docs branch from 7e59a66 to 9a39692 Compare June 25, 2024 03:04
@seans3 seans3 changed the title [KEP-4006] PLACEHOLDER - Docs for PortForward over WebSockets Feature Gates (Beta) [KEP-4006] - Docs for PortForward over WebSockets Feature Gates (Beta) Jul 25, 2024
@seans3 seans3 marked this pull request as ready for review July 25, 2024 17:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2024
@Princesso
Copy link
Contributor

Hello @seans3 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@sftim
Copy link
Contributor

sftim commented Jul 26, 2024

If a review is needed @Princesso, the folks to ask are @kubernetes/sig-docs-en-reviews

@tengqm
Copy link
Contributor

tengqm commented Jul 27, 2024

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2024
@Princesso
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Princesso, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Princesso
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0cf0076da66cf8c96b2d5f44f45a8d2d528d335d

@k8s-ci-robot k8s-ci-robot merged commit fd52687 into kubernetes:dev-1.31 Jul 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@sftim sftim Awaiting requested review from sftim

@tengqm tengqm Awaiting requested review from tengqm

@reylejano reylejano Awaiting requested review from reylejano

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@Princesso Princesso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
6 participants
@seans3 @dipesh-rawat @Princesso @sftim @tengqm @k8s-ci-robot