Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog post about OCI volume sources / KEP-4639 #46960

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Blog post about OCI volume sources / KEP-4639 #46960

merged 1 commit into from
Aug 13, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 25, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2024
@saschagrunert saschagrunert mentioned this pull request Jun 25, 2024
Open
9 tasks
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 969c669
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a348c93dc33400084bfea9
😎 Deploy Preview https://deploy-preview-46960--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jun 25, 2024

/label area/blog

/hold
pending:

  • v1.31 release
  • assignment of publication date (by release comms)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2024
@k8s-ci-robot
Copy link
Contributor

@sftim: The label(s) `/label area/blog

cannot be applied. These labels are supported:api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labelsorlabels -> restricted_labelsinplugin.yaml`?

In response to this:

/label area/blog

/hold
pending:

  • v1.31 release
  • assignment of publication date (by release comms)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sftim
Copy link
Contributor

sftim commented Jun 25, 2024

/area blog

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Jun 25, 2024
@hailkomputer
Copy link
Member

Hello, I'm Yigit, from the 1.31 Release comms team. I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024. Please let me know how we can help!

@saschagrunert
Copy link
Member Author

I'm going to start working on this blog post this week.

@saschagrunert saschagrunert force-pushed the oci-volumesource-blog branch 2 times, most recently from afe4712 to 303a455 Compare July 23, 2024 08:55
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 23, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2024
@saschagrunert saschagrunert force-pushed the oci-volumesource-blog branch 3 times, most recently from bde322f to 8196378 Compare July 24, 2024 09:35
@saschagrunert saschagrunert changed the title [WIP] Blog post about OCI volume sources / KEP-4639 Blog post about OCI volume sources / KEP-4639 Jul 24, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2024
@saschagrunert
Copy link
Member Author

Ready for review. PTAL @kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 24, 2024
tengqm
tengqm reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.
A few nits for consideration.

content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
@saschagrunert
Copy link
Member Author

Overall LGTM. A few nits for consideration.

Thank you for the review! I applied the suggestions.

@sftim
Copy link
Contributor

sftim commented Jul 24, 2024

@hailkomputer what publication date would you like to assign?

sftim
sftim reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks for the PR.

We can approve it only once the publication date is confirmed, and can unhold it once v1.31 is released.

content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-08-15-kubernetes-1.31-image-volume-source.md Outdated Show resolved Hide resolved
@hailkomputer
Copy link
Member

Hello thank you once again for the PR @saschagrunert .
@sftim, assigned publication date is Aug 16, 2024. Please let us know if we can help further.

@saschagrunert
Blog post about OCI volume sources / KEP-4639
969c669 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

Hello thank you once again for the PR @saschagrunert . @sftim, assigned publication date is Aug 16, 2024. Please let us know if we can help further.

Thanks, updated the PR to reflect the new publication date.

@tengqm
Copy link
Contributor

tengqm commented Jul 27, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2024
sftim
sftim reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0572e22d3ef134b3a4c9056331ed41ce197bd99d

@saschagrunert
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6b9ad4a into kubernetes:main Aug 13, 2024
6 checks passed
@saschagrunert saschagrunert deleted the oci-volumesource-blog branch August 14, 2024 06:59
@lavishpal lavishpal mentioned this pull request Sep 18, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavishpal lavishpal lavishpal left review comments

@sftim sftim sftim left review comments

@tengqm tengqm tengqm left review comments

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
SIG Node: code and documentation PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saschagrunert @sftim @k8s-ci-robot @hailkomputer @tengqm @lavishpal