Clarify image change restart behavior for sidecar containers #47024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sftim
reviewed
Jun 30, 2024
k8s-ci-robot
added
size/S
dshebib
force-pushed
the
fixClarifyInitcontainerImageRestart
branch
from
eb9659d to
6f8395e
Compare
|
@sftim included your comments |
11 tasks
k8s-ci-robot
added
the
needs-rebase
|
@dshebib Please help resolve the conflicts. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
dshebib
force-pushed
the
fixClarifyInitcontainerImageRestart
branch
from
6f8395e to
31de2ea
Compare
k8s-ci-robot
added
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9bcab797531ab92aa2a8f644a2ff2d458d566fd6
|
sftim
reviewed
Jan 14, 2025
k8s-ci-robot
added
the
sig/node
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
my-git9
pushed a commit
to my-git9/website-1
that referenced
this pull request
Jan 15, 2025
…nerImageRestart Clarify image change restart behavior for sidecar containers Signed-off-by: xin.li <xin.li@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that only chaging the image of a sidecar container will not restart the pod.
Previously had contradicting information:
Altering an init container image field is equivalent to restarting the Pod.and
The Pod will not be restarted when the init container image is changed,xref: kubernetes/kubernetes#121333