Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Windows CPU and Memory Affinity #48469

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Docs: Windows CPU and Memory Affinity #48469

merged 7 commits into from
Nov 25, 2024

Conversation

jsturtevant
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 21, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sjenning October 21, 2024 16:57
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 7f411ed
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/673ffcb7f4bba50008d9f5da

@jsturtevant jsturtevant mentioned this pull request Oct 21, 2024
Open
9 tasks
@jsturtevant jsturtevant marked this pull request as draft October 21, 2024 17:01
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7f411ed
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673ffcb7a060ec000817c6c1
😎 Deploy Preview https://deploy-preview-48469--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/sig windows
/sig node

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 21, 2024
@jsturtevant jsturtevant marked this pull request as ready for review October 22, 2024 20:19
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@k8s-ci-robot k8s-ci-robot requested a review from klueska October 22, 2024 20:19
@jsturtevant jsturtevant marked this pull request as draft October 22, 2024 20:19
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@chanieljdan
Copy link
Contributor

Hi @jsturtevant 👋

Just a reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review ahead of the "Ready for Review" deadline on Tuesday November 19th 2024 18:00 PST.

Thank you!

@marosset marosset mentioned this pull request Nov 8, 2024
Merged
@chanieljdan
Copy link
Contributor

Hi @jsturtevant 👋 ,

A quick reminder to get your PR ready for review before the deadline, Tuesday November 19th at 18:00 PDT. For additional information, refer to: Documenting for a release - PR Ready for Review.

Thank you!

@jsturtevant
Add docs for Windows CPU and Memory Managers
e2cccab 
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@jsturtevant jsturtevant marked this pull request as ready for review November 18, 2024 23:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot requested a review from bg-chun November 18, 2024 23:04
tengqm
tengqm reviewed Nov 19, 2024
View reviewed changes
...docs/reference/command-line-tools-reference/feature-gates/windows-cpu-and-memory-affinity.md Outdated Show resolved Hide resolved
...docs/reference/command-line-tools-reference/feature-gates/windows-cpu-and-memory-affinity.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/cpu-management-policies.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/cpu-management-policies.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/cpu-management-policies.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/memory-manager.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/memory-manager.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/memory-manager.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/topology-manager.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/topology-manager.md Outdated Show resolved Hide resolved
@jsturtevant @marosset
@tengqm @aravindhp
Apply suggestions from code review
ce1491d 
Co-authored-by: Mark Rossetti <marosset@microsoft.com>
Co-authored-by: Qiming Teng <tengqm@outlook.com>
Co-authored-by: Aravindh Puthiyaparambil <aravindhp@users.noreply.github.com>
@jsturtevant
Updates based on feedback
bdc9bef 
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
ffromani
ffromani reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from sig-node, the docs technical content looks correct and reflecting what we did.

@ffromani ffromani mentioned this pull request Nov 21, 2024
Merged
@jsturtevant @tengqm
Update content/en/docs/tasks/administer-cluster/cpu-management-polici…
bd84bba 
…es.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>
@jsturtevant
Copy link
Contributor Author

/assign @tengqm

@jsturtevant
Copy link
Contributor Author

/assign @marosset @aravindhp

tengqm
tengqm reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than some nits.

content/en/docs/tasks/administer-cluster/cpu-management-policies.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/memory-manager.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/topology-manager.md Outdated Show resolved Hide resolved
jsturtevant and others added 3 commits November 21, 2024 19:37
@jsturtevant @tengqm
Update content/en/docs/tasks/administer-cluster/cpu-management-polici…
6ca0d52 
…es.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>
@jsturtevant @tengqm
Update content/en/docs/tasks/administer-cluster/memory-manager.md
0867522 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@jsturtevant @tengqm
Update content/en/docs/tasks/administer-cluster/topology-manager.md
7f411ed 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@chanieljdan
Copy link
Contributor

Technical LGTM provided above

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 638adb68cc2ba994b76e4a31f1dea65c6ae3f970

@chanieljdan
Copy link
Contributor

@tengqm could we get your final review/approval on this one? thanks!

marosset
marosset approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm from sig-windows

@chanieljdan
Copy link
Contributor

Technical and Docs LGTM noted above

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chanieljdan, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 64ac7c4 into kubernetes:dev-1.32 Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani ffromani left review comments

@aravindhp aravindhp aravindhp left review comments

@tengqm tengqm tengqm left review comments

@marosset marosset marosset approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@sjenning sjenning Awaiting requested review from sjenning

@klueska klueska Awaiting requested review from klueska

@bg-chun bg-chun Awaiting requested review from bg-chun

Assignees

@tengqm tengqm

@chanieljdan chanieljdan

@aravindhp aravindhp

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Status: Done
[sig-windows] PR tracking
Status: Done
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
8 participants
@jsturtevant @dipesh-rawat @chanieljdan @k8s-ci-robot @tengqm @aravindhp @marosset @ffromani