Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes v1.32 sneak peek blog #48585

Merged
merged 27 commits into from
Nov 7, 2024
Merged

Conversation

mbianchidev
Copy link
Member

@mbianchidev mbianchidev commented Oct 29, 2024

Add 2024-11-04-kubernetes-1.32-sneak-peek.md
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Oct 29, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2024
Copy link

netlify bot commented Oct 29, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 61d8b11
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/672caeda90b284000836d0d5
😎 Deploy Preview https://deploy-preview-48585--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbianchidev
Copy link
Member Author

mbianchidev commented Oct 29, 2024

mbianchidev and others added 6 commits October 29, 2024 15:29
Update content/en/blog/_posts/2024-11-04-kubernetes-1.32-sneak-peek.md

Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Update content/en/blog/_posts/2024-11-04-kubernetes-1.32-sneak-peek.md

Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Update 2024-11-04-kubernetes-1.32-sneak-peek.md
Update 2024-11-04-kubernetes-1.32-sneak-peek.md
Update 2024-11-04-kubernetes-1.32-sneak-peek.md
Update content/en/blog/_posts/2024-11-04-kubernetes-1.32-sneak-peek.md

Co-authored-by: Filip Křepinský <fkrepins@redhat.com>
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overarching feedback:

  • Section title casing to be amended from KEP ABCD to KEP ABCD
  • It'd be beneficial to add the one-line enhancement description as the title instead of reinventing the wheel, IMO.
  • Casing for section titles should adhere to style guide.

mbianchidev and others added 2 commits October 30, 2024 09:09
Update content/en/blog/_posts/2024-11-04-kubernetes-1.32-sneak-peek.md

Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Update 2024-11-04-kubernetes-1.32-sneak-peek.md
@mbianchidev
Copy link
Member Author

Overarching feedback:

  • Section title casing to be amended from KEP ABCD to KEP ABCD
  • It'd be beneficial to add the one-line enhancement description as the title instead of reinventing the wheel, IMO.
  • Casing for section titles should adhere to style guide.

Hey @divya-mohan0209 thanks a lot for taking a look at this so quickly!
I amended the KEP titles and same goes for the section titles, can you take a look to see if everything looks fine now?

Regarding the one-line-enhancement description as title we decided not to do that for a couple of reasons:

  • Sometimes the one line description is not that descriptive for people who might not have context; see the allowing all characters in env variables one;
  • Adding some flavor (and pop culture) to this blog to make it a bit more fun to read;
  • Creating extra sections having an umbrella title and subtitles like the Windows and the DRA ones.

Of course we are happy to change the titles in case we need to.
Let me know!

Copy link
Member

@ArvindParekh ArvindParekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor spelling and formatting nits.
Thank you.

Update 2024-11-04-kubernetes-1.32-sneak-peek.md
Update 2024-11-04-kubernetes-1.32-sneak-peek.md
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A copy-edit and spelling pass. Feel free to take or leave any given suggestion. Also, I had to refresh mid-review; I've checked for consistency, but I apologize if anything seems misaligned or outdated.

Update 2024-11-04-kubernetes-1.32-sneak-peek.md
@mbianchidev
Copy link
Member Author

A copy-edit and spelling pass. Feel free to take or leave any given suggestion. Also, I had to refresh mid-review; I've checked for consistency, but I apologize if anything seems misaligned or outdated.

Thank you so much @nate-double-u !
I implemented most of your suggestions, just some slight changes - sorry for the mid-review refresh but I was probably addressing other comments.
It's all good, I really appreciate your contribution and feedback.

Update 2024-11-08-kubernetes-1.32-sneak-peek.md
mbianchidev and others added 3 commits November 6, 2024 11:30
Update content/en/blog/_posts/2024-11-08-kubernetes-1.32-sneak-peek.md

Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Update content/en/blog/_posts/2024-11-08-kubernetes-1.32-sneak-peek.md

Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Update 2024-11-08-kubernetes-1.32-sneak-peek.md
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2024
@mbianchidev
Copy link
Member Author

Removed the enhancements not tracked for code freeze as agreed @fsmunoz, seeking approve and LGTM labels from @kubernetes/sig-docs-blog-owners

@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 7, 2024

@mbianchidev looks good to me, ty!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4faf0b370cd18db93d4db51e7c63e8de61721399

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Thank you for your work on this, @mbianchidev :)

Left some suggestions to improve overall clarity, and we should be good to go, IMO.

Update content/en/blog/_posts/2024-11-08-kubernetes-1.32-sneak-peek.md

Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2024
@k8s-ci-robot k8s-ci-robot requested a review from fsmunoz November 7, 2024 12:12
Update content/en/blog/_posts/2024-11-08-kubernetes-1.32-sneak-peek.md

Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
@mbianchidev
Copy link
Member Author

Thank you so much @divya-mohan0209 for this last minute review!

Addressed your comments, PTAL.

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging @natalisucks for the final approve!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 139c0ebf231795e6b80c15ed04f0538f4708e116

@natalisucks
Copy link
Contributor

thanks everyone for your great work on this!
/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 7, 2024

Looking great, thank you all as well!

@k8s-ci-robot k8s-ci-robot merged commit 53ceaeb into kubernetes:main Nov 7, 2024
6 checks passed
@mbianchidev mbianchidev deleted the patch-1 branch December 6, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.